Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Introduce runtime check that it is root isolate that makes UI native calls. #18050

Merged
aam merged 5 commits into from
May 1, 2020
Merged

Introduce runtime check that it is root isolate that makes UI native calls. #18050

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
198b278
Revert "Do not register UI-related native functions in secondary isol…
aam Apr 29, 2020
0dcc5d9
Confirm it is root isolate that makes UI native calls.
aam Apr 30, 2020
da0bc8b
Fix format, UIDartState reference from Fuchsia source
aam Apr 30, 2020
3fb38cc
No UI isolate check for fuchsia calls
aam Apr 30, 2020
2860be3
Fix typo. Remove redundant runtime calls
aam Apr 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix format, UIDartState reference from Fuchsia source
  • Loading branch information
@aam
aam committed Apr 30, 2020
commit da0bc8b5c559e4ac5cd338c5a2d10729539570c0
2 changes: 1 addition & 1 deletion lib/ui/compositing/scene_host.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ using SceneHostBindings = std::unordered_map<SceneHostBindingKey,
static SceneHostBindings scene_host_bindings;

void SceneHost_constructor(Dart_NativeArguments args) {
UIDartState::ThrowIfUIOperationsProhited();
flutter::UIDartState::ThrowIfUIOperationsProhited();
tonic::DartCallConstructor(&flutter::SceneHost::Create, args);
}

Expand Down
4 changes: 2 additions & 2 deletions lib/ui/dart_ui.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ void DartUI::InitForGlobal() {

void DartUI::InitForIsolate() {
FML_DCHECK(g_natives);
Dart_Handle result = Dart_SetNativeResolver(Dart_LookupLibrary(
ToDart("dart:ui")), GetNativeFunction, GetSymbol);
Dart_Handle result = Dart_SetNativeResolver(
Dart_LookupLibrary(ToDart("dart:ui")), GetNativeFunction, GetSymbol);
if (Dart_IsError(result)) {
Dart_PropagateError(result);
}
Expand Down