Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ran formatter
  • Loading branch information
gaaclarke committed Jul 10, 2020
commit 5eb302f58853bfa6d444e19c9dad86461a9cb744
18 changes: 0 additions & 18 deletions fml/platform/darwin/scoped_nsobject.h
Original file line number Diff line number Diff line change
Expand Up @@ -70,24 +70,6 @@ class scoped_nsprotocol {

NST get() const { return object_; }

void swap(scoped_nsprotocol& that) {
NST temp = that.object_;
that.object_ = object_;
object_ = temp;
}

// scoped_nsprotocol<>::release() is like scoped_ptr<>::release. It is NOT a
// wrapper for [object_ release]. To force a scoped_nsprotocol<> to call
// [object_ release], use scoped_nsprotocol<>::reset().
[[nodiscard]] NST release() {
NST temp = object_;
object_ = nil;
return temp;
}

// Shift reference to the autorelease pool to be released later.
NST autorelease() { return [release() autorelease]; }

private:
NST object_;
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ - (BOOL)compareGoldenToImage:(UIImage*)image {
const char* apos = rawA.mutableBytes;
const char* bpos = rawB.mutableBytes;
double sum = 0.0;
for(size_t i = 0; i < size; ++i, ++apos, ++bpos) {
for (size_t i = 0; i < size; ++i, ++apos, ++bpos) {
double aval = *apos;
double bval = *bpos;
double diff = aval - bval;
Expand Down
2 changes: 1 addition & 1 deletion testing/scenario_app/run_ios_tests.sh
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ pushd ios/Scenarios

set -o pipefail && xcodebuild -sdk iphonesimulator \
-scheme Scenarios \
-destination 'platform=iOS Simulator,name=iPhone 8' \
-destination 'platform=iOS Simulator,name=iPhone 8,OS=13.0' \
test \
FLUTTER_ENGINE=$FLUTTER_ENGINE | $PRETTY

Expand Down