Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

FrameTiming build start timestamp fix and add vsync start timestamp #20229

Merged
fluttergithubbot merged 8 commits into from
Aug 8, 2020
Merged

FrameTiming build start timestamp fix and add vsync start timestamp #20229

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
01ace70
Change frame build time start timestamp
CareF Jul 30, 2020
84a11d6
add vsync start to layer_tree
CareF Aug 4, 2020
0ec79db
add test
CareF Aug 4, 2020
35d1bd8
formatting
CareF Aug 4, 2020
87d0982
move tracing
CareF Aug 4, 2020
8c7178c
remove vsync_time method
CareF Aug 4, 2020
3d14526
bug fix and formatting
CareF Aug 4, 2020
ecca65e
update constructor
CareF Aug 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
move tracing
  • Loading branch information
@CareF
CareF committed Aug 6, 2020
commit 87d0982be761ff907f90369075988e8cb05fee31
3 changes: 3 additions & 0 deletions shell/common/animator.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,9 @@ void Animator::BeginFrame(fml::TimePoint vsync_start_time,

last_frame_begin_time_ = fml::TimePoint::Now();
Copy link
Contributor

@iskakaushik iskakaushik Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when we post a trace event for VsyncSchedulingOverhead we also use fml::TimePoint::Now(). Can we unify both these and maybe post a trace event here instead?

Copy link
Contributor Author

@CareF CareF Aug 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not 100% sure I understand but I made a commit moving the TaceEventAsyncComplete line. PTAL.

last_vsync_start_time_ = vsync_start_time;
fml::tracing::TraceEventAsyncComplete("flutter", "VsyncSchedulingOverhead",
last_frame_begin_time_,
last_frame_begin_time_);
last_frame_target_time_ = frame_target_time;
dart_frame_deadline_ = FxlToDartOrEarlier(frame_target_time);
{
Expand Down
3 changes: 0 additions & 3 deletions shell/common/vsync_waiter.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,6 @@ void VsyncWaiter::FireCallback(fml::TimePoint frame_start_time,
[callback, flow_identifier, frame_start_time, frame_target_time]() {
FML_TRACE_EVENT("flutter", kVsyncTraceName, "StartTime",
frame_start_time, "TargetTime", frame_target_time);
fml::tracing::TraceEventAsyncComplete(
"flutter", "VsyncSchedulingOverhead", fml::TimePoint::Now(),
frame_start_time);
callback(frame_start_time, frame_target_time);
TRACE_FLOW_END("flutter", kVsyncFlowName, flow_identifier);
},
Expand Down