Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use hint freed specifically for image disposal #20754

Merged
dnfield merged 17 commits into from
Sep 2, 2020
Merged

Use hint freed specifically for image disposal #20754

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
fa3cce8
Use hint freed specifically for image disposal
dnfield Aug 25, 2020
7b35fb3
update tests, license file
dnfield Aug 26, 2020
eee1b33
test that is hopefully not flaky!
dnfield Aug 26, 2020
3666025
Update image_dispose_unittests.cc
dnfield Aug 26, 2020
d9a6a8d
Deflake?
dnfield Aug 26, 2020
44330c5
Merge branch 'image_dispose' of github.com:dnfield/engine into image_…
dnfield Aug 26, 2020
8b19c6c
deflaked
dnfield Aug 27, 2020
e972933
merge
dnfield Sep 1, 2020
c154c46
Fix windows?
dnfield Sep 1, 2020
68b3151
Deflake by adding .. a timeout :(
dnfield Sep 1, 2020
b82af7b
Deflake by adding .. a timeout :(
dnfield Sep 1, 2020
d09f46b
make it safer
dnfield Sep 2, 2020
35e376b
..
dnfield Sep 2, 2020
c8a52b7
merge
dnfield Sep 2, 2020
c6ee6f3
Merge branch 'image_dispose' of github.com:dnfield/engine into image_…
dnfield Sep 2, 2020
fd59059
Merge remote-tracking branch 'upstream/master' into image_dispose
dnfield Sep 2, 2020
fcf2217
split changees to new pr
dnfield Sep 2, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix windows?
  • Loading branch information
@dnfield
dnfield committed Sep 1, 2020
commit c154c464fc231bbd9ed013842877f111c29cd128
5 changes: 2 additions & 3 deletions lib/ui/painting/image_dispose_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,8 @@ TEST_F(ImageDisposeTest, ImageReleasedAfterFrame) {
current_image_ = image->image();
current_picture_ = picture->picture();

Dart_NewFinalizableHandle(
Dart_HandleFromWeakPersistent(picture->dart_wrapper()),
&picture_finalizer_latch_, 0, &picture_finalizer);
Dart_NewFinalizableHandle(Dart_GetNativeArgument(args, 1),
&picture_finalizer_latch_, 0, &picture_finalizer);
};

auto native_on_begin_frame_done = [&](Dart_NativeArguments args) {
Expand Down