Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Fix image gap due to svg element without position attribute #21939

Merged
ferhatb merged 9 commits into from
Oct 20, 2020
Merged

[web] Fix image gap due to svg element without position attribute #21939

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a56bcf1
Fix image gap due to svg element without position attribute
ferhatb Oct 17, 2020
d8a5139
remove screenshot write
ferhatb Oct 17, 2020
bf7b8f4
Merge remote-tracking branch 'upstream/master' into filter_gap
ferhatb Oct 19, 2020
00752be
update golden lock
ferhatb Oct 19, 2020
ad7f334
address reviewer comments on style
ferhatb Oct 19, 2020
9f7e9fe
Merge remote-tracking branch 'upstream/master' into filter_gap
ferhatb Oct 19, 2020
8ee91f5
remove unnecessary null comparisons
ferhatb Oct 19, 2020
5da6afb
Merge remote-tracking branch 'upstream/master' into filter_gap
ferhatb Oct 19, 2020
f0dbaf6
Merge remote-tracking branch 'upstream/master' into filter_gap
ferhatb Oct 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address reviewer comments on style
  • Loading branch information
@ferhatb
ferhatb committed Oct 19, 2020
commit ad7f334e82bc273c7593f8a50c547103d6b36e8e
2 changes: 1 addition & 1 deletion lib/web_ui/lib/src/engine/util.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,7 +503,7 @@ final ByteData? _fontChangeMessage =
bool _fontChangeScheduled = false;

FutureOr<void> sendFontChangeMessage() async {
if (window._onPlatformMessage != null) if (!_fontChangeScheduled) {
if (window._onPlatformMessage != null && !_fontChangeScheduled) {
_fontChangeScheduled = true;
// Batch updates into next animationframe.
html.window.requestAnimationFrame((num _) {
Expand Down
2 changes: 1 addition & 1 deletion lib/web_ui/test/golden_tests/engine/color_filter_golden_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ Picture _drawTestPictureWithImage(ColorFilter filter) {
PictureRecorder() as EnginePictureRecorder;
final RecordingCanvas canvas =
recorder.beginRecording(const Rect.fromLTRB(0, 0, 400, 400));
Image testImage = createTestImage();
final Image testImage = createTestImage();
canvas.drawImageRect(
testImage,
Rect.fromLTWH(0, 0, 200, 150),
Expand Down