Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@fredlee12345678
Copy link
Contributor

Description

Replace this paragraph with a description of what this PR is doing. If you're
modifying existing behavior, describe the existing behavior, how this PR is
changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from our issue
database
. Indicate, which of these issues are resolved or fixed by this PR.
There should be at least one issue listed here.

Tests

I added the following tests:

Replace this with a list of the tests that you added as part of this PR. A
change in behaviour with no test covering it will likely get reverted
accidentally sooner or later. PRs must include tests for all
changed/updated/fixed behaviors. See testing the engine for instructions on
writing and running engine tests.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • [x ] I read and followed the C++, Objective-C, Java style guides for the engine.
  • [x ] I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • [x ] I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

Breaking Change

Did any tests fail when you ran them? Please read handling breaking changes.

@flar
Copy link
Contributor

flar commented Nov 5, 2020

Some code complexity could be reduced by putting the flag in the context so that only layers that care about the condition will need to be modified.

Also, an alternative could be to set the cull rect to kGiantRect in those layers that don't want their inherited culling rect to be passed on. This wouldn't require an additional flag.

@chinmaygarde chinmaygarde added the Work in progress (WIP) Not ready (yet) for review! label Nov 12, 2020
@flar
Copy link
Contributor

flar commented Nov 12, 2020

I have another fix for this issue being reviewed under #22336

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes Work in progress (WIP) Not ready (yet) for review!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants