This repository was archived by the owner on Feb 25, 2025. It is now read-only.
PlatformViewIOS CreateExternalViewEmbedder refactor #22353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskakaushik
force-pushed
the
ios-pv-create-eve
branch
2 times, most recently
from
3e4e727 to
4287d50
Compare
iskakaushik
force-pushed
the
ios-pv-create-eve
branch
from
4287d50 to
044e028
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 13, 2020
flar
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 13, 2020
* 03ff8a4 TBR: remove the extra values which was overshadowing the test result (flutter/engine#22483) * e9b6a42 Roll Skia from a06b63c56ecd to 8ead30d51c86 (1 revision) (flutter/engine#22487) * ee70051 Roll Fuchsia Linux SDK from fULjPqtx9... to B4PaMsNWM... (flutter/engine#22490) * 4cbb684 Roll Dart SDK from 3e502e0c7e04 to 41893ff76b0f (1 revision) (flutter/engine#22491) * 38b6c22 PlatformViewIOS CreateExternalViewEmbedder refactor (flutter/engine#22353) * bbcf19a Roll Skia from 8ead30d51c86 to 011218edb590 (4 revisions) (flutter/engine#22493)
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes it so that external view embedders are no longer needed by ios surfaces and the only place where the external view embedder is creates is PlatformViewIOS.