Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Nov 6, 2020

@yjbanov yjbanov requested a review from jakemac53 November 6, 2020 21:40
@google-cla google-cla bot added the cla: yes label Nov 6, 2020
path: 1.8.0-nullsafety.3
test: 1.14.3
test: 1.16.0-nullsafety.9
quiver: 2.1.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw quiver does now have a null safety release, if you want to use it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@yjbanov yjbanov requested a review from nturgut November 6, 2020 22:30
Copy link
Contributor

@nturgut nturgut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

As long as the integration tests are also passing, one more measure we can take is patching PR: #22260 and running felt on different modes/build backends.

@yjbanov yjbanov merged commit 1e3ceb0 into flutter:master Nov 7, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 7, 2020
chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020
* update pubspecs to null-safe dependencies

* remove build_runner dep; upgrade quiver

* use analysis_options.yaml to control analysis scope
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix legacy import violations in web_ui

4 participants