This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add Instrumentation class to web engine #22650
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
yjbanov
force-pushed
the
instrumentation
branch
from
d722aa8 to
7ce1e7f
Compare
| _update(initialValue); | ||
| if (Instrumentation.enabled) { | ||
| Instrumentation.instance.incrementCounter( | ||
| '${_skDeletable?.constructor.name} created', |
Contributor
There was a problem hiding this comment.
Could we get 'null created' and 'null deleted'? How should we make sense of those?
Contributor
Author
There was a problem hiding this comment.
I have not seen any nulls yet. I'm not sure how to make sense of that situation. I think let's wait until we get a null and find a solution then.
harryterkelsen
approved these changes
Nov 20, 2020
Contributor
harryterkelsen
left a comment
harryterkelsen
left a comment
There was a problem hiding this comment.
LGTM with comment for discussion
yjbanov
force-pushed
the
instrumentation
branch
from
7ce1e7f to
cd741d1
Compare
yjbanov
added
the
waiting for tree to go green
yjbanov
changed the title
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 24, 2020
chaselatta
pushed a commit
to chaselatta/engine
that referenced
this pull request
Nov 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
Instrumentationclass for counting events that happen in the engine.