This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove use of package:test and package:mockito from flutter_frontend_… #26040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
May 10, 2021
| import 'package:path/path.dart' as path; | ||
|
|
||
| import 'package:test/test.dart'; | ||
| import 'utils.dart'; |
Contributor
There was a problem hiding this comment.
FWIW, both mockito and test are available in //third_party/dart/third_party/pkg.
But getting rid of mockito will vastly simplify NNBD migration.
Member
Author
There was a problem hiding this comment.
Yeah, nnbd is why I wanted to get rid of mockito. Getting rid of package:test has two benefits.
- Many fewer path dependencies to explicitly override in the pubspec.yaml.
- And therefore less chance that the dependencies will have version conflicts so that we can use
pub get --offlineto generate thepackage_config.json.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2021
…rontend_server tests (flutter/engine#26040)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2021
…rontend_server tests (flutter/engine#26040)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 11, 2021
…rontend_server tests (flutter/engine#26040)
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
May 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of flutter/flutter#82134