This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add ability to stamp fuchsia packages with API level #29851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaselatta
force-pushed
the
fuchsia_api_level
branch
from
0d80c16 to
22d61a5
Compare
akbiggs
approved these changes
Nov 19, 2021
| rebase_path(manifest_json_file, root_build_dir), | ||
| ] | ||
|
|
||
| if (fuchsia_target_api_level != -1) { |
Contributor
There was a problem hiding this comment.
sorry, I'm still struggling with GN :( where does this variable come from? Do all gn_args[] get put into the namespace as variables automatically?
Contributor
Author
There was a problem hiding this comment.
It comes from the import above where we import //build/fuchsia/config.gni. This is a gn thing, when you put a variable in a declare_args it makes it available as a global after an import.
chaselatta
force-pushed
the
fuchsia_api_level
branch
from
22d61a5 to
9492e59
Compare
chaselatta
added
the
waiting for tree to go green
arbreng
approved these changes
Nov 22, 2021
| if args.api_level is not None: | ||
| build_command = ['--api-level', args.api_level] + build_command | ||
|
|
||
| archive_command = ['archive', '--output='+ os.path.join(os.path.dirname(output_dir), args.far_name + "-0")] |
Contributor
There was a problem hiding this comment.
Can you file a bug to get rid of the -0? It complicates people's workflows because the fars aren't named that everywhere, only in our repo. It's also useless since it's just an arbitrary thing we hardcore here
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to pass the target fuchsia api level to GN for stamping packages. We are not specifying the specific API level yet.
BUG: https://bugs.fuchsia.dev/p/fuchsia/issues/detail?id=87813