This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Add Spell Check Support for Android Engine #30858
Merged
Merged
Changes from 1 commit
Commits
Show all changes
72 commits
Select commit
Hold shift + click to select a range
dc93719
Add session management
camsim99 cd234ad
Handle receiving results
camsim99 f463846
Add framework logic, modify engine
camsim99 3dfae0a
Make engine build
camsim99 546692b
Add retrieving locale
camsim99 5f43ff5
Added comments for experimentation
camsim99 ee73219
Send string back temporarily, fix results representation
camsim99 624f68b
Formatting
camsim99 846b195
Merge branch 'main' of github.com:flutter/engine into issue_34688_dev
camsim99 b27704c
Merge remote-tracking branch 'upstream/main' into issue_34688_dev
camsim99 64f0ac7
Add new method channel
camsim99 0cc3776
Add platform setting for spell check
camsim99 33f2f40
Change method channel name
camsim99 eb3c731
Remove print statements
camsim99 1877242
Clean up
camsim99 5372aaa
Formatting
camsim99 d9adbdc
Clean PR
camsim99 34809db
Undo platform plugin changes
camsim99 10d154d
Clean up code
camsim99 00c228e
Begin adding tests
camsim99 e08171f
Formatting
camsim99 5ccc144
Correct sessions, remove unecessary line
camsim99 87ab60f
Add tests
camsim99 f4083d7
Formatting
camsim99 ce45427
Remove variable
camsim99 6972b0b
Begin fixing tests
camsim99 3eba4de
Address reviews
camsim99 963d9ae
Start fixing systesm setting
camsim99 6ea2ede
Continue addressing reviews
camsim99 32c7702
Continue addressing reviews
camsim99 e9ebd5b
Fix spell checkers check
camsim99 8298436
Begin fixing tests
camsim99 993b6c8
Reformat FlutterViewTest
camsim99 4179f42
Fixing tests
camsim99 f999488
Merge remote-tracking branch 'upstream/main' into issue_34688_dev
camsim99 ade72bc
Fix tests minus log errors
camsim99 c20b62c
Add context shadow to stub tsm request
camsim99 49583d4
Formatting
camsim99 49939aa
Fix np error
camsim99 0cf00f3
Add license
camsim99 48a4354
Update licenses file
camsim99 510f83a
Add nativeSpellCheckServiceDefined to other platform dispatchers
camsim99 d8e333b
Merge remote-tracking branch 'upstream/main' into issue_34688_dev
camsim99 61908d3
Remove setting
camsim99 29b095f
Fix typos
camsim99 ee28058
Update lib/ui/platform_dispatcher.dart
camsim99 4f0a074
Update lib/ui/window.dart
camsim99 6c4d437
Update shell/platform/android/io/flutter/embedding/android/FlutterVie…
camsim99 d73b915
Update shell/platform/android/io/flutter/embedding/engine/systemchann…
camsim99 66c24ed
Update shell/platform/android/io/flutter/embedding/engine/systemchann…
camsim99 04a2ce1
Update shell/platform/android/io/flutter/embedding/engine/systemchann…
camsim99 15d17f5
Update shell/platform/android/io/flutter/embedding/engine/systemchann…
camsim99 e6414b2
Update shell/platform/android/io/flutter/embedding/engine/systemchann…
camsim99 2882e3b
Update shell/platform/android/io/flutter/embedding/engine/systemchann…
camsim99 dfe4689
Update shell/platform/android/io/flutter/plugin/editing/SpellCheckPlu…
camsim99 cdc6b9c
Update shell/platform/android/io/flutter/plugin/editing/SpellCheckPlu…
camsim99 65b8850
Update shell/platform/android/io/flutter/plugin/editing/SpellCheckPlu…
camsim99 036b15b
Make review fixes
camsim99 188c2ad
Merge branch 'issue_34688_dev' of github.com:camsim99/engine into iss…
camsim99 8198d4e
Formatting
camsim99 a2b6c90
Fix spell check test
camsim99 2aac372
Address nits
camsim99 894f4e9
Send text to framework
camsim99 2a4ea66
Push for visibility
camsim99 c2a6550
Modify result response protocol
camsim99 6125e74
Merge branch 'main' into issue_34688_dev
camsim99 74d1477
Merge remote-tracking branch 'upstream/master' into issue_34688_dev
camsim99 cc8bf5e
Merge branch 'issue_34688_dev' of github.com:camsim99/engine into iss…
camsim99 5a175ec
Formatting and pull
camsim99 1c02784
Merge remote-tracking branch 'upstream/master' into issue_34688_dev
camsim99 3e74d61
Emulator fix
camsim99 975673c
Merge remote-tracking branch 'upstream/main' into issue_34688_dev
camsim99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Continue addressing reviews
- Loading branch information
commit 6ea2ede534531a1c358c8d96ba1bb6b15c6e2d7f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.