[ci.yaml] Fix xcode 13 cache to not contain dashes #32325
Conversation
.ci.yaml
Outdated
| {"name":"openjdk","path":"java"}, | ||
| {"name":"xcode_runtime_ios-13-0","path":"xcode_runtime_ios-13-0"}, | ||
| {"name":"xcode_runtime_ios-15-0","path":"xcode_runtime_ios-15-0"} | ||
| {"name":"xcode_runtime_ios_13_0","path":"xcode_runtime_ios-13-0"}, |
There was a problem hiding this comment.
This comment should be updated then?
https://flutter.googlesource.com/recipes/+/refs/heads/main/recipe_modules/osx_sdk/api.py#96
I'm assuming the cache names don't matter since I previously made up osx_sdk_13a233_13_15
There was a problem hiding this comment.
I'll send the recipes CL, and hopefully no person has to worry about whether your cache has a dash or not...
| {"name":"osx_sdk_13a233_13_15","path":"osx_sdk"}, | ||
| {"name":"builder_mac_engine","path":"builder"}, | ||
| {"name":"openjdk","path":"java"}, | ||
| {"name":"xcode_runtime_ios-13-0","path":"xcode_runtime_ios-13-0"}, |
There was a problem hiding this comment.
It looks like the recipe module is expecting ios- with a dash?
'iOS %s.simruntime' % version.lower().replace('ios-', '').replace('-', '.')
https://flutter.googlesource.com/recipes/+/refs/heads/main/recipe_modules/osx_sdk/api.py#211
There was a problem hiding this comment.
Ah nevermind that's coming from the runtime_versions property, not the cache.
jmagman
left a comment
jmagman
left a comment
There was a problem hiding this comment.
LGTM if it's caching correctly on this change.
|
Submitting to fix ci.yaml rolls and the corresponding flutter/infra change has landed. |
2 participants
flutter/flutter#100985
Test
Pre-launch Checklist
writing and running engine tests.
///).