Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Add backdrop filter support; refactor EntityPass #33887

Merged
fluttergithubbot merged 13 commits into from
Jun 15, 2022
Merged

[Impeller] Add backdrop filter support; refactor EntityPass #33887

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0e4963f
Move inline renderpass state machine into a new object to simplify On…
bdero Jun 7, 2022
9bbbed6
Separate Element->Entity resolution into its own routine
bdero Jun 7, 2022
068ac3d
Move pass context into its own TU
bdero Jun 7, 2022
fa09ec7
Add backdrop filter support
bdero Jun 7, 2022
74f34d1
Beef up the test
bdero Jun 7, 2022
64fb54a
Fix coverage behavior
bdero Jun 7, 2022
d808f61
Address comment
bdero Jun 7, 2022
30f3f21
Licenses
bdero Jun 7, 2022
813764d
Address comment
bdero Jun 7, 2022
d91a750
Fix coverage again
bdero Jun 8, 2022
3648828
Incorporate post-filter coverage
bdero Jun 8, 2022
3a96049
Always use maximal coverage
bdero Jun 10, 2022
eb372e6
Use enum
bdero Jun 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address comment
  • Loading branch information
@bdero
bdero committed Jun 7, 2022
commit d808f61d417abce251133ddbe22086458a493ea8
7 changes: 2 additions & 5 deletions impeller/display_list/display_list_dispatcher.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,11 +380,8 @@ void DisplayListDispatcher::saveLayer(const SkRect* bounds,
const flutter::SaveLayerOptions options,
const flutter::DlImageFilter* backdrop) {
auto paint = options.renders_with_attributes() ? paint_ : Paint{};
if (backdrop) {
canvas_.SaveLayer(paint, ToRect(bounds), ToImageFilterProc(backdrop));
} else {
canvas_.SaveLayer(paint, ToRect(bounds));
}
canvas_.SaveLayer(paint, ToRect(bounds),
backdrop ? ToImageFilterProc(backdrop) : std::nullopt);
Copy link
Contributor

@flar flar Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking more along the lines of just:

canvas_.SaveLayer(paint, ToRect(bounds), ToImageFilterProc(backdrop));

since ToIFP handles null already...

Copy link
Member Author

@bdero bdero Jun 7, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoopsies, went too fast here. Fixed.

}

// |flutter::Dispatcher|
Expand Down