Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Clean up text input configuration in clearTextInputClient #34209

Merged
auto-submit merged 4 commits into from
Jun 24, 2022
Merged

Clean up text input configuration in clearTextInputClient #34209

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3095463
Clean up text input configuration in clearTextInputClient
LongCatIsLooong Jun 21, 2022
c752816
fix NPE
LongCatIsLooong Jun 22, 2022
9a9b1db
whoops
LongCatIsLooong Jun 22, 2022
09b12fb
Merge remote-tracking branch 'upstream/main' into fix-autofill-crash
LongCatIsLooong Jun 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix NPE
  • Loading branch information
@LongCatIsLooong
LongCatIsLooong committed Jun 22, 2022
commit c752816eb78a1bceb05c03bcba5d14cf2dc1a4ba
4 changes: 2 additions & 2 deletions shell/platform/android/io/flutter/plugin/editing/TextInputPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,11 +714,11 @@ public void autofill(@NonNull SparseArray<AutofillValue> values) {
return;
}

final TextInputChannel.Configuration.Autofill currentAutofill = configuration.autofill;
if (currentAutofill == null || autofillConfiguration == null) {
if (configuration == null || autofillConfiguration == null || configuration.autofill == null) {
return;
}

final TextInputChannel.Configuration.Autofill currentAutofill = configuration.autofill;
final HashMap<String, TextInputChannel.TextEditState> editingValues = new HashMap<>();
for (int i = 0; i < values.size(); i++) {
int virtualId = values.keyAt(i);
Expand Down