Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[gn + codesign] mac code sign configuration for FlutterMacOS.framework.zip #35707

Merged
auto-submit merged 12 commits into from
Feb 17, 2023
Merged

[gn + codesign] mac code sign configuration for FlutterMacOS.framework.zip #35707

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
864119c
embed codesign config in macos framework
XilaiZhang Aug 25, 2022
d65a90f
Merge remote-tracking branch 'upstream/main' into xilaizhang-macos-1
XilaiZhang Aug 25, 2022
2198a07
format files
XilaiZhang Aug 25, 2022
78895ec
Merge remote-tracking branch 'upstream/main' into xilaizhang-macos-1
XilaiZhang Aug 25, 2022
a8deeed
update path
XilaiZhang Aug 25, 2022
0c14ba7
Merge remote-tracking branch 'upstream/main' into xilaizhang-macos-1
XilaiZhang Jan 18, 2023
d42b961
Merge remote-tracking branch 'upstream/main' into xilaizhang-macos-1
XilaiZhang Jan 18, 2023
c705283
Merge remote-tracking branch 'upstream/main' into xilaizhang-macos-1
XilaiZhang Feb 13, 2023
e459033
y flag for outer layer zip
XilaiZhang Feb 16, 2023
330d147
Merge remote-tracking branch 'upstream/main' into xilaizhang-macos-1
XilaiZhang Feb 16, 2023
a565154
simplify structure
XilaiZhang Feb 17, 2023
f55c612
format files
XilaiZhang Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
format files
  • Loading branch information
@XilaiZhang
XilaiZhang committed Aug 25, 2022
commit 2198a078017d569f18bf6854498083fbf76d4ea2
8 changes: 7 additions & 1 deletion sky/tools/create_macos_framework.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,10 +96,12 @@ def main():
return 1
process_framework(dst, args, fat_framework, fat_framework_binary)


def embed_codesign_configuration(config_path, content):
with open(config_path, 'w') as f:
f.write(content)


def process_framework(dst, args, fat_framework, fat_framework_binary):
if args.dsym:
dsym_out = os.path.splitext(fat_framework)[0] + '.dSYM'
Expand Down Expand Up @@ -131,7 +133,11 @@ def process_framework(dst, args, fat_framework, fat_framework_binary):

# Zip FlutterMacOS.framework.
subprocess.check_call([
Copy link
Member

@jmagman jmagman Aug 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the resolution for #35623 that was reverted here #35680, because it was expected to not have entitlements? I'm not sure how these without_entitlements files work.

https://github.com/flutter/flutter/blob/fefb2b00bab8548e66aa09849dbd51c4b9c357d1/dev/conductor/core/lib/src/codesign.dart#L188

@christopherfujino

Copy link
Contributor Author

@XilaiZhang XilaiZhang Aug 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry didn't realize there is an engine PR review on Thursday. These without_entiltements and 'entitlements.txt` are just text files embedded in the zip artifacts, not going to affect the correctness of anything.

Copy link
Contributor Author

@XilaiZhang XilaiZhang Aug 25, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inspecting locally, looks like the symlinks are dropped in the build process. Current assumption is based on #35673.

Copy link
Contributor

@godofredoc godofredoc Feb 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready for review?

'zip', '-r', 'FlutterMacOS.framework.zip', 'FlutterMacOS.framework', 'entitlements.txt',
'zip',
'-r',
'FlutterMacOS.framework.zip',
'FlutterMacOS.framework',
'entitlements.txt',
'without_entitlements.txt',
],
cwd=dst)
Expand Down