Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Engine startup event timed after VM initializes #35713

Merged
yaakovschectman merged 5 commits into from
Aug 31, 2022
Merged

Engine startup event timed after VM initializes #35713

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ac334e5
Engine startup event timed after VM initializes
yaakovschectman Aug 23, 2022
e2d0691
Formatting
yaakovschectman Aug 25, 2022
a4f0dc8
Update FlutterEngineMainEnter event comment
yaakovschectman Aug 26, 2022
a11e0a4
Remove engine_start_time
yaakovschectman Aug 30, 2022
f53100c
Remove unused variable
yaakovschectman Aug 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove unused variable
  • Loading branch information
@yaakovschectman
yaakovschectman committed Aug 30, 2022
commit f53100c2c778f332860c66bbc4d8a736f9f9d336
12 changes: 6 additions & 6 deletions runtime/dart_vm.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,12 +473,12 @@ DartVM::DartVM(std::shared_ptr<const DartVMData> vm_data,
// we are interested in only one timestamp.
int64_t micros = Dart_TimelineGetMicros();
Dart_TimelineEvent("FlutterEngineMainEnter", // label
micros, // timestamp0
micros, // timestamp1_or_async_id
Dart_Timeline_Event_Instant, // event type
0, // argument_count
nullptr, // argument_names
nullptr // argument_values
micros, // timestamp0
micros, // timestamp1_or_async_id
Dart_Timeline_Event_Instant, // event type
0, // argument_count
nullptr, // argument_names
nullptr // argument_values
);
}

Expand Down
2 changes: 0 additions & 2 deletions shell/platform/android/flutter_main.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,6 @@ void FlutterMain::Init(JNIEnv* env,
settings.enable_timeline_event_handler = settings.trace_systrace;
#endif // FLUTTER_RELEASE

int64_t init_time_micros = initTimeMillis * 1000;

// Restore the callback cache.
// TODO(chinmaygarde): Route all cache file access through FML and remove this
// setter.
Expand Down