This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Remove extract_far.dart #35801
Merged
Remove extract_far.dart #35801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
akbiggs
approved these changes
Aug 30, 2022
11 tasks
Member
|
Needs a license file update. |
Member
Author
@zanderso how does the removal of a single .dart file we own trigger needing to update a license file? And how do I do that? |
Member
|
The edit that's needed is noted in the logs for the "Linux License" check. See the bottom of: |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 31, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 31, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 31, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 31, 2022
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 31, 2022
* d782c33 [web] roll CanvasKit to 0.36.1 (flutter/engine#35747) * 300592b allows mallocmapping copies of size zero (flutter/engine#35803) * 61e4c07 Generate mac os framework with a global generator. (flutter/engine#35673) * 7a03a54 Roll Skia from 545e45ab4d5d to 27a2eeacd330 (11 revisions) (flutter/engine#35805) * 89909d9 Fix DartPerformanceMode enum mismatch (flutter/engine#35806) * ead1348 Queue all semantic nodes & actions before completing batch (flutter/engine#35792) * adec6ed Run clang-tidy and Mac Unopt on Xcode beta (flutter/engine#35793) * eb6e2e0 Roll Skia from 27a2eeacd330 to 18b36bd2e2a3 (1 revision) (flutter/engine#35807) * e74352c Remove extract_far.dart (flutter/engine#35801) * 5ee7b38 Test cover 'toImage'. (flutter/engine#35791) * 8ed1e6c Roll Skia from 18b36bd2e2a3 to 7c67a21eec59 (3 revisions) (flutter/engine#35810) * cc2a323 Roll Dart SDK from 9faec45da06c to 7e5a69f6b25f (1 revision) (flutter/engine#35811) * c2a2a56 Roll Fuchsia Linux SDK from NwG1XTWHxB9R3XcU5... to usGLIrlCJW1C1yaF1... (flutter/engine#35812) * 8ab3b8f Migrate testing/symbols to null safety (flutter/engine#35809) * 7e27b92 Roll Skia from 7c67a21eec59 to 3abad1ab16cc (1 revision) (flutter/engine#35816) * 4cb5be0 [web] remove references to IE11 and old Edge; treat Samsung browser as Blink (flutter/engine#35205) * 5154b8a Roll Fuchsia Mac SDK from 4GZkuoQmvVanO84uA... to V_dBCcwGfOqJkrG9b... (flutter/engine#35817) * b5a5a0d Roll Dart SDK from 7e5a69f6b25f to 5a2737b71877 (1 revision) (flutter/engine#35818) * e114573 [dart:ui] Adds a reusable FragmentShader (flutter/engine#35253) * 26d6bcf Roll Skia from 3abad1ab16cc to a7829f6da292 (1 revision) (flutter/engine#35819) * 6c9f6f5 Roll Skia from a7829f6da292 to 83b5d7ae4bca (2 revisions) (flutter/engine#35821) * 169181f Make shader mask layer code builder aware (flutter/engine#35622) * 06925ed Roll Fuchsia Linux SDK from usGLIrlCJW1C1yaF1... to 5YEIlndU4ncjOl9I_... (flutter/engine#35824) * 7a40a0a Roll Skia from 83b5d7ae4bca to e4a2061eb1fc (1 revision) (flutter/engine#35826) * 43ee40e Engine startup event timed after VM initializes (flutter/engine#35713) * 9eb524b Roll Fuchsia Mac SDK from V_dBCcwGfOqJkrG9b... to sgXD5SyRPOxGjWV4q... (flutter/engine#35829) * cfdc83a Roll Skia from e4a2061eb1fc to 34df0f94c849 (1 revision) (flutter/engine#35828) * 90d65fa fix null access for CkParagraph.dispose (flutter/engine#35815) * ef039c1 Update the API check script for the latest Dart analyzer APIs (flutter/engine#35831) * c3c8727 Revert "[web] roll CanvasKit to 0.36.1 (#35747)" (flutter/engine#35837) * db97b55 Roll Skia from 34df0f94c849 to e0b87738eca7 (5 revisions) (flutter/engine#35832) * f69e0cc add enterkeyhint property to web textfields (flutter/engine#35411) * 54a1b59 Add a comment in the scenario app to meet the latest analyzer requirements (flutter/engine#35838) * d993e0d Revert "[dart:ui] Adds a reusable FragmentShader (#35253)" (flutter/engine#35843)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
shell/platform/fuchsia/flutter/kernel/extract_far.dartas it doesn't support null safety, and the understanding is that it's no longer used.Contributes to flutter/flutter#110020
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.