Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@stuartmorgan-g
Copy link
Contributor

Cherry-picks #35997 to the stable branch.

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-3.2-candidate.5 to main September 9, 2022 16:23
@flutter-dashboard
Copy link

This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to flutter-3.2-candidate.5. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot added embedder Related to the embedder API platform-android platform-web Code specifically for the web engine platform-windows labels Sep 9, 2022
@stuartmorgan-g stuartmorgan-g changed the base branch from main to flutter-3.2-candidate.5 September 9, 2022 16:37
@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 1.
View them at https://flutter-engine-gold.skia.org/cl/github/36046

@itsjustkevin
Copy link
Contributor

@stuartmorgan the two tests are still failing on rerun. I am investigating, can you take a look in parallel?

@stuartmorgan-g
Copy link
Contributor Author

Neither of those tests look even remotely related to the code I changed, so I think something is wrong with the CP target branch itself.

@skia-gold
Copy link

Gold has detected about 1 new digest(s) on patchset 2.
View them at https://flutter-engine-gold.skia.org/cl/github/36046

@itsjustkevin itsjustkevin self-requested a review September 13, 2022 14:40
@itsjustkevin itsjustkevin merged commit 769c845 into flutter:flutter-3.2-candidate.5 Sep 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

embedder Related to the embedder API platform-android platform-web Code specifically for the web engine platform-windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants