Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland "Support basic back navigation in Android 13/API 33 #35678" #36051

Merged
auto-submit merged 4 commits into from
Sep 12, 2022
Merged

Reland "Support basic back navigation in Android 13/API 33 #35678" #36051

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63e9310
Revert "Revert "Support basic back navigation in Android 13/API 33" (…
GaryQian Sep 9, 2022
9194685
Add suppress warning to workaround google3 lint bug
GaryQian Sep 9, 2022
4945dfc
Add TODO
GaryQian Sep 9, 2022
4e181f0
Add git issue link
GaryQian Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add git issue link
  • Loading branch information
@GaryQian
GaryQian committed Sep 9, 2022
commit 4e181f012c717777681862e4771af5a941774bb9
2 changes: 1 addition & 1 deletion shell/platform/android/io/flutter/embedding/android/FlutterActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -543,7 +543,7 @@ public void unregisterOnBackInvokedCallback() {
? new OnBackInvokedCallback() {
// TODO(garyq): Remove SuppressWarnings annotation. This was added to workaround
// a google3 bug where the linter is not properly running against API 33, causing
// a failure here. See b/243609613
// a failure here. See b/243609613 and https://github.com/flutter/flutter/issues/111295
@SuppressWarnings("Override")
Copy link
Contributor

@stuartmorgan-g stuartmorgan-g Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a TODO for removing this, explaining when it can be removed (probably best to file a Flutter issue tracking it to reference in the TODO, and reference the internal bug in that issue along with any other useful context).

Copy link
Contributor Author

@GaryQian GaryQian Sep 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Filed flutter/flutter#111295 and added TODO.

@Override
public void onBackInvoked() {
Expand Down