Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
address review comments
  • Loading branch information
mdebbar committed Nov 8, 2022
commit b4c7c4a2e72c3efe1357ff9a91f69f0e86ba08d6
2 changes: 1 addition & 1 deletion lib/web_ui/lib/src/engine/dom.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1667,7 +1667,7 @@ Iterable<T> createDomListWrapper<T>(_DomList list) =>
class DomIntl {}

extension DomIntlExtension on DomIntl {
/// This is a Chrome-only API for segmenting text.
/// This is a V8-only API for segmenting text.
///
/// See: https://code.google.com/archive/p/v8-i18n/wikis/BreakIterator.wiki
external Object? get v8BreakIterator;
Expand Down
6 changes: 2 additions & 4 deletions lib/web_ui/lib/src/engine/text/line_breaker.dart
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,7 @@ abstract class LineBreakFragmenter extends TextFragmenter {
}

@override
List<LineBreakFragment> fragment() {
return _computeLineBreakFragments(text);
}
List<LineBreakFragment> fragment();
}

/// Flutter web's custom implementation of [LineBreakFragmenter].
Expand All @@ -64,7 +62,7 @@ class FWLineBreakFragmenter extends TextFragmenter implements LineBreakFragmente
}
}

/// An implementation of [LineBreakFragmenter] that uses Chrome's
/// An implementation of [LineBreakFragmenter] that uses V8's
/// `v8BreakIterator` API to find line breaks in the given [text].
class V8LineBreakFragmenter extends TextFragmenter implements LineBreakFragmenter {
V8LineBreakFragmenter(super.text)
Expand Down