Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Clang tidy and web engine cherrypicks #37660

Merged
godofredoc merged 7 commits into from
Nov 16, 2022
Merged

Clang tidy and web engine cherrypicks #37660

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
832e83e
clang-tidy: added the ability to shard jobs (#37265)
gaaclarke Nov 7, 2022
e4e9d15
Clang-tidy: Fixed math on shard-id validator. (#37433)
gaaclarke Nov 8, 2022
b71cbbc
Felt analyze (#37481)
eyebrowsoffire Nov 10, 2022
776d7f4
Run pub get before building host.dart. (#37502)
eyebrowsoffire Nov 11, 2022
9411e5d
Skip the skwasm unit test suite on Safari since it is flaky. (#37602)
eyebrowsoffire Nov 15, 2022
7fa5bf4
Remove felt snapshotting behavior. (#37639)
eyebrowsoffire Nov 15, 2022
491591d
Combine results of all the test batches. (#37610)
hterkelsen Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip the skwasm unit test suite on Safari since it is flaky. (#37602) 
* Skip the skwasm unit test suite on Safari since it is flaky.

* Add TODO.
  • Loading branch information
@eyebrowsoffire @godofredoc
eyebrowsoffire authored and godofredoc committed Nov 16, 2022
commit 9411e5d3d1592315f0379bb5091f94f3eacba82b
5 changes: 4 additions & 1 deletion lib/web_ui/dev/steps/run_tests_step.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,10 @@ class RunTestsStep implements PipelineStep {
);
}

if (sortedTests.skwasmTests.isNotEmpty) {
// TODO(jacksongardner): enable this test suite on safari
// For some reason, Safari is flaky when running the Skwasm test suite
// See https://github.com/flutter/flutter/issues/115312
if (browserName != kSafari && sortedTests.skwasmTests.isNotEmpty) {
await _runTestBatch(
testFiles: sortedTests.skwasmTests,
renderer: Renderer.skwasm,
Expand Down