Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add back tooltip to Embedder #37676

Merged
yaakovschectman merged 4 commits into from
Nov 16, 2022
Merged

Add back tooltip to Embedder #37676

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6fc6568
Add back tooltip to Embedder
yaakovschectman Nov 16, 2022
7568bcd
Test inclusion of tooltip data
yaakovschectman Nov 16, 2022
d1492fa
Change to constexpr
yaakovschectman Nov 16, 2022
5da0ee4
Lint
yaakovschectman Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change to constexpr
  • Loading branch information
@yaakovschectman
yaakovschectman committed Nov 16, 2022
commit d1492fae699e417e14235bfbfd8e26481896028e
3 changes: 2 additions & 1 deletion shell/platform/embedder/tests/embedder_a11y_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ namespace testing {

using EmbedderA11yTest = testing::EmbedderTest;

const static char tooltip[] = "tooltip";
constexpr static char tooltip[] = "tooltip";

TEST_F(EmbedderTest, CannotProvideNewAndLegacySemanticsCallback) {
EmbedderConfigBuilder builder(
Expand Down Expand Up @@ -288,6 +288,7 @@ TEST_F(EmbedderA11yTest, A11yTreeIsConsistentUsingLegacyCallbacks) {
ASSERT_EQ(7.0, node->transform.pers0);
ASSERT_EQ(8.0, node->transform.pers1);
ASSERT_EQ(9.0, node->transform.pers2);
ASSERT_EQ(std::strncmp(node->tooltip, tooltip, sizeof(tooltip) - 1), 0);

if (node->id == 128) {
ASSERT_EQ(0x3f3, node->platform_view_id);
Expand Down