Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Turn on darwin-* clang-tidy checks #37814

Merged
auto-submit merged 1 commit into from
Nov 22, 2022
Merged

Turn on darwin-* clang-tidy checks #37814

auto-submit merged 1 commit into from
Nov 22, 2022

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Nov 21, 2022

Turn on checks:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman marked this pull request as ready for review November 21, 2022 23:30
@jmagman jmagman requested a review from cbracken November 21, 2022 23:30
cbracken
cbracken approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 22, 2022
@auto-submit auto-submit bot merged commit 3c27847 into flutter:main Nov 22, 2022
@jmagman jmagman deleted the darwin-clang-tidy branch November 22, 2022 23:09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Nov 23, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 23, 2022
@engine-flutter-autoroll
3c27847 Turn on darwin-* clang-tidy checks (flutter/engine#37814)
0abf576
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Nov 23, 2022
@engine-flutter-autoroll
Roll Flutter Engine from a805eff to 4bf16c3 (2 revisions) (#115888)
7bb1d1b 
* 3c27847 Turn on darwin-* clang-tidy checks (flutter/engine#37814)

* 4bf16c3 Turn on objc-* clang-tidy checks (flutter/engine#37813)
shogohida pushed a commit to shogohida/flutter that referenced this pull request Dec 7, 2022
@engine-flutter-autoroll @shogohida
Roll Flutter Engine from a805eff to 4bf16c3 (2 revisions) (flutter#11…
f1a248c 
…5888)

* 3c27847 Turn on darwin-* clang-tidy checks (flutter/engine#37814)

* 4bf16c3 Turn on objc-* clang-tidy checks (flutter/engine#37813)
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
@engine-flutter-autoroll @gspencergoog
Roll Flutter Engine from a805eff to 4bf16c3 (2 revisions) (flutter#11…
f77d899 
…5888)

* 3c27847 Turn on darwin-* clang-tidy checks (flutter/engine#37814)

* 4bf16c3 Turn on objc-* clang-tidy checks (flutter/engine#37813)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@cbracken cbracken cbracken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios platform-macos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @cbracken