Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add setImageSampler (for replacing setSampler) #37821

Merged
auto-submit merged 11 commits into from
Nov 22, 2022
Merged

Add setImageSampler (for replacing setSampler) #37821

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f1daacf
Add setImageSampler (for replacing setSampler)
bdero Nov 21, 2022
ecb29be
Includes
bdero Nov 21, 2022
4190467
Remove deprecation tag, just in case there are roll problems
bdero Nov 21, 2022
5a5021f
Remove comment
bdero Nov 21, 2022
6e9c9a0
Fix comment
bdero Nov 21, 2022
e43e5f5
Add setImageSampler for canvaskit
bdero Nov 22, 2022
f56bfed
Remove arg
bdero Nov 22, 2022
0a353bb
Fix conversion
bdero Nov 22, 2022
0109a0d
Float64List
bdero Nov 22, 2022
0d00c73
final...
bdero Nov 22, 2022
da6f1cb
Pass along the engine handle
bdero Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove deprecation tag, just in case there are roll problems
  • Loading branch information
@bdero
bdero committed Nov 21, 2022
commit 4190467bfb65c3ba286cf559a3d7e73782c713e0
1 change: 0 additions & 1 deletion lib/ui/painting.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4335,7 +4335,6 @@ class FragmentShader extends Shader {
/// results will be undefined.
///
/// Use of this method may result in poor performance with the Impeller backend.
Copy link
Contributor

@jonahwilliams jonahwilliams Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be careful about describing something as having poor performance with no refernce point. I've seen users go to extensive lengths to avoid invoking apis that have warnings like this, sometimes exceeding the original performance cost.

Copy link
Member Author

@bdero bdero Nov 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, removed this.

@Deprecated('Use setImageSampler instead.')
void setSampler(int index, ImageShader sampler) {
assert(!debugDisposed, 'Tried to access uniforms on a disposed Shader: $this');
_setSampler(index, sampler);
Expand Down