Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[macOS] Make FlutterEngine support multiple views #37976

Merged
auto-submit merged 14 commits into from
Feb 9, 2023
Merged

[macOS] Make FlutterEngine support multiple views #37976

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
74503c6
Rebase all
dkwingsmt Jan 26, 2023
e249299
Do not remove views on hot restart
dkwingsmt Jan 26, 2023
f5335ea
Remove log, fix doc
dkwingsmt Jan 26, 2023
fd7d3d9
Apply suggestions from code review
dkwingsmt Feb 2, 2023
d705c82
Merge remote-tracking branch 'origin/main' into multiview-engine
dkwingsmt Feb 2, 2023
3ac89d9
getDefaultView
dkwingsmt Feb 2, 2023
0f44c6d
postpone deprecation. Add TODO
dkwingsmt Feb 3, 2023
9de9616
Apply suggestions from code review
dkwingsmt Feb 6, 2023
ad69a76
Merge remote-tracking branch 'origin/main' into multiview-engine
dkwingsmt Feb 7, 2023
c05f0e8
Change to single
dkwingsmt Feb 7, 2023
c2ebe66
Update FlutterEngine.h
dkwingsmt Feb 9, 2023
0625db7
Update FlutterEngine_Internal.h
dkwingsmt Feb 9, 2023
63a41c9
Merge remote-tracking branch 'origin/main' into multiview-engine
dkwingsmt Feb 9, 2023
d063600
Merge remote-tracking branch 'dkwingsmt/multiview-engine' into multiv…
dkwingsmt Feb 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update FlutterEngine_Internal.h
  • Loading branch information
@dkwingsmt
dkwingsmt authored Feb 9, 2023
commit 0625db733e5dbadff925199f1f867a99ddf7e361
2 changes: 1 addition & 1 deletion shell/platform/darwin/macos/framework/Source/FlutterEngine_Internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
* the given controller, if successfully attached, will always have the default
* view ID kFlutterDefaultViewId.
*
* The engine holds a weak reference to the attached view controller.
* The engine holds a weak reference to the attached view controller.
*
* If the given view controller is already attached to an engine, this call
* throws an assertion.
Expand Down