Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller Scene] Parse GLTF primitives #38064

Merged
bdero merged 7 commits into from
Dec 5, 2022
Merged

[Impeller Scene] Parse GLTF primitives #38064

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dce50b1
Bump buildroot
bdero Dec 5, 2022
09bb019
[Impeller Scene] Parse GLTF geometry
bdero Dec 5, 2022
a9d668e
Add Divisor cast
bdero Dec 5, 2022
c34e192
Address comments
bdero Dec 5, 2022
ab0bb2f
Improve scalar conversion mechanism
bdero Dec 5, 2022
8e807cb
Use source type for divisor
bdero Dec 5, 2022
c917e70
Better wording
bdero Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Better wording
  • Loading branch information
@bdero
bdero committed Dec 5, 2022
commit c917e708601535b524c8ad9963efe244d8c50b77
6 changes: 3 additions & 3 deletions impeller/scene/importer/vertices_builder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ void VerticesBuilder::WriteFBVertices(std::vector<fb::Vertex>& vertices) const {
}

/// @brief Reads a contiguous sequence of numeric components from `source` and
/// writes them to `destination` buffer as 32bit floats. Signed
/// SourceTypes convert to a range of -1 to 1, and unsigned SourceTypes
/// convert to a range of 0 to 1.
/// writes them to `destination` as 32bit floats. Signed SourceTypes
/// convert to a range of -1 to 1, and unsigned SourceTypes convert to a
/// range of 0 to 1.
template <typename SourceType>
static void WriteComponentsAsScalars(void* destination,
const void* source,
Expand Down