Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller Scene] Import animation data #38583

Merged
auto-submit merged 5 commits into from
Jan 2, 2023
Merged

[Impeller Scene] Import animation data #38583

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ae6a8cc
[Impeller Scene] Import animation data
bdero Dec 31, 2022
e2baafc
Cast
bdero Dec 31, 2022
6654f3b
Use correct length modifier
bdero Dec 31, 2022
6408ed4
Fix translation import
bdero Jan 2, 2023
ba950b2
Use ++ instead of fetch_add
bdero Jan 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use correct length modifier
  • Loading branch information
@bdero
bdero committed Dec 31, 2022
commit 6654f3bb6164bb1713367ce7c1d7e44d24cbd553
5 changes: 2 additions & 3 deletions impeller/scene/node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

#include "impeller/scene/node.h"

#include <inttypes.h>
#include <atomic>
#include <memory>

Expand Down Expand Up @@ -193,9 +194,7 @@ void Node::UnpackFromFlatbuffer(
}
}

Node::Node()
: name_(SPrintF("__node%llu",
static_cast<uint64_t>(kNextNodeID.fetch_add(1)))){};
Node::Node() : name_(SPrintF("__node%" PRIu64, kNextNodeID.fetch_add(1))){};
Copy link
Member

@chinmaygarde chinmaygarde Jan 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could just use operator++ for these atomics which does the same thing and perhaps is a bit clearer.

Copy link
Member Author

@bdero bdero Jan 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh, that's nice. Done.


Node::~Node() = default;

Expand Down