Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Merge MSAA alert functionality with UIA #38745

Merged
yaakovschectman merged 23 commits into from
Jan 19, 2023
Merged

Merge MSAA alert functionality with UIA #38745

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
3be3387
Use AXFragmentRootWin for MSAA functionality.
yaakovschectman Dec 16, 2022
3465272
Removing unused code
yaakovschectman Jan 10, 2023
1a7171b
Remove unused files
yaakovschectman Jan 10, 2023
0a20b2f
Flip macro
yaakovschectman Jan 10, 2023
7f78a69
Formatting
yaakovschectman Jan 10, 2023
8982f08
Licenses
yaakovschectman Jan 10, 2023
77ee7b9
Make reference
yaakovschectman Jan 10, 2023
6352acd
Disable copy constructor/assignment
yaakovschectman Jan 10, 2023
bfa0289
Unused import
yaakovschectman Jan 10, 2023
5aa4c77
Formatting
yaakovschectman Jan 10, 2023
2970345
Relocate alert logic
yaakovschectman Jan 10, 2023
ae7ea18
Remove comment and unused mock
yaakovschectman Jan 10, 2023
463b74b
Fix unit test
yaakovschectman Jan 10, 2023
4abf2a1
Idempotency
yaakovschectman Jan 11, 2023
2dfe876
Formatting
yaakovschectman Jan 11, 2023
0ab2478
PR feedback
yaakovschectman Jan 11, 2023
efe2657
Doc comments
yaakovschectman Jan 11, 2023
42d7721
Undo string change for now
yaakovschectman Jan 11, 2023
cfedb56
Couple fragment root and alert node
yaakovschectman Jan 13, 2023
5373390
Formatting
yaakovschectman Jan 13, 2023
48f0315
Add comments
yaakovschectman Jan 17, 2023
111ad30
Pointer to reference
yaakovschectman Jan 17, 2023
d32c151
Typo fix
yaakovschectman Jan 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Formatting
  • Loading branch information
@yaakovschectman
yaakovschectman committed Jan 11, 2023
commit 5aa4c778a3256bf8bb040b1bcb2292aea7b88cd8
6 changes: 4 additions & 2 deletions shell/platform/common/alert_platform_node_delegate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,13 @@ namespace flutter {

class AlertPlatformNodeDelegate : public ui::AXPlatformNodeDelegateBase {
Copy link
Member

@cbracken cbracken Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a doc comment. (True, we lack a lot in existing code but good to remedy in new code)

Copy link
Member

@loic-sharma loic-sharma Jan 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do a pass, there's several other fields that are also missing comments

public:
explicit AlertPlatformNodeDelegate(ui::AXPlatformNodeDelegate* parent_delegate);
explicit AlertPlatformNodeDelegate(
ui::AXPlatformNodeDelegate* parent_delegate);
~AlertPlatformNodeDelegate();

AlertPlatformNodeDelegate(const AlertPlatformNodeDelegate& other) = delete;
AlertPlatformNodeDelegate operator=(const AlertPlatformNodeDelegate& other) = delete;
AlertPlatformNodeDelegate operator=(const AlertPlatformNodeDelegate& other) =
delete;

void SetText(const std::u16string& text);
Copy link
Member

@cbracken cbracken Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider void SetText(std::u16string_view text);. It's super lightweight, sometimes better performance, and allows for passing a char16_t* string as well (unlikely as that is).

Copy link
Contributor Author

@yaakovschectman yaakovschectman Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AXNodeData methods that this method calls take string& parameters. Am I mistaken that constructing a string from a string_view effectively copies it?

Copy link
Member

@loic-sharma loic-sharma Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also leaning towards keeping this a string reference, but, the string reference is also copied when AXNodeData stores it as an attribute.

Copy link
Member

@cbracken cbracken Jan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AXNodeData methods that this method calls take string& parameters. Am I mistaken that constructing a string from a string_view effectively copies it?

Yes - to benefit from this, you'd need any methods this gets passed to to also take a view rather than a string ref. If the current implementation is doing so, then leave as-is; at some point we can do a sweep of the codebase to clean these up across the board.


Expand Down