Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Map UVs correctly for TiledTextureContents #38894

Merged
bdero merged 3 commits into from
Jan 16, 2023
Merged

[Impeller] Map UVs correctly for TiledTextureContents #38894

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e24aeab
[Impeller Scene] Generate correct UVs for TiledTextureContents
bdero Jan 15, 2023
7342e1f
Use correct item in unittests
bdero Jan 16, 2023
8013207
Add issue link
bdero Jan 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add issue link
  • Loading branch information
@bdero
bdero committed Jan 16, 2023
commit 8013207da1978699d17a9bc960899f10cc1fee18
1 change: 1 addition & 0 deletions impeller/entity/contents/tiled_texture_contents.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ bool TiledTextureContents::Render(const ContentContext& renderer,
// TODO(bdero): The geometry should be fetched from GetPositionUVBuffer and
Copy link
Member

@zanderso zanderso Jan 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a link to an issue here?

Copy link
Member Author

@bdero bdero Jan 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

// contain coverage-mapped UVs, and this should use
// position_uv.vert.
// https://github.com/flutter/flutter/issues/118553

VS::VertInfo vert_info;
vert_info.mvp = geometry_result.transform;
Expand Down