Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add more flexible image loading API #38905

Merged
auto-submit merged 9 commits into from
Jan 23, 2023
Merged

Add more flexible image loading API #38905

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
759c980
Add more flexible image loading API
tvolkert Jan 16, 2023
b095f72
Add test
tvolkert Jan 16, 2023
e6371f3
Fixed test failure
tvolkert Jan 16, 2023
ca4dc78
Update
tvolkert Jan 18, 2023
1a026b3
Add web implementation
tvolkert Jan 19, 2023
5c7d830
Fixed typo
tvolkert Jan 19, 2023
cb7cf84
Review comments
tvolkert Jan 19, 2023
d31fa58
Forgot to remove the _SizeOnlyImageDescriptor class - it's no longer …
tvolkert Jan 19, 2023
3d79727
Forgot to update test
tvolkert Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed typo
  • Loading branch information
@tvolkert
tvolkert committed Jan 20, 2023
commit 5c7d8302c5fef3ff0a1c0b83d49d635cb0a0c8dc
2 changes: 1 addition & 1 deletion lib/web_ui/lib/painting.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,7 +501,7 @@ class _SizeOnlyImageDescriptor implements ImageDescriptor {
final int height;

@override
dynamic noSuchMethod(Invocation invocation) => throw UnsupportedError('ImageDescriptor.${invocation.method} is not supported on web within a TargetImageSizeCallback.');
dynamic noSuchMethod(Invocation invocation) => throw UnsupportedError('ImageDescriptor.${invocation.memberName} is not supported on web within a TargetImageSizeCallback.');
Copy link
Contributor

@jonahwilliams jonahwilliams Jan 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nooooooooo, can we avoid using noSuchMethod? :)

Copy link
Contributor

@yjbanov yjbanov Jan 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this can really blow up the JS bundle size.

Copy link
Contributor Author

@tvolkert tvolkert Jan 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL! I'll update it. Reason I went with this is because it was forcing me to implement all the private methods too, which was a bummer.

Copy link
Contributor Author

@tvolkert tvolkert Jan 19, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - I got rid of the need for the ImageDescriptor at all.

}

Future<Codec> instantiateImageCodecWithSize(
Expand Down