Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[ios] Fix hold and drag spacebar does not move cursor when obscureText is true. #40216

Merged
auto-submit merged 3 commits into from
Apr 25, 2023
Merged

[ios] Fix hold and drag spacebar does not move cursor when obscureText is true. #40216

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe4ac52
[ios] fix hold and drag spacebar does not move cursor when obscureTex…
LinXunFeng Mar 10, 2023
ca8094b
add test
LinXunFeng Mar 11, 2023
8bd7030
supplementary test to judge whether reloadInputViews method is called
LinXunFeng Mar 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test
  • Loading branch information
@LinXunFeng
LinXunFeng committed Apr 9, 2023
commit ca8094b2eb2b5ddf11b880de61c807bccde2adf7
25 changes: 25 additions & 0 deletions shell/platform/darwin/ios/framework/Source/FlutterTextInputPluginTest.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,14 @@ - (FlutterTextRange*)getLineRangeFromTokenizer:(id<UITextInputTokenizer>)tokeniz
return (FlutterTextRange*)range;
}

- (void)updateConfig:(NSDictionary*)config {
FlutterMethodCall* updateConfigCall =
[FlutterMethodCall methodCallWithMethodName:@"TextInput.updateConfig" arguments:config];
[textInputPlugin handleMethodCall:updateConfigCall
result:^(id _Nullable result){
}];
}

#pragma mark - Tests

- (void)testWillNotCrashWhenViewControllerIsNil {
Expand Down Expand Up @@ -647,6 +655,23 @@ - (void)testPropagatePressEventsToViewController2 {
withEvent:[OCMArg isNotNil]]);
}

- (void)testUpdateSecureTextEntry {
NSDictionary* config = self.mutableTemplateCopy;
[config setValue:@"YES" forKey:@"obscureText"];
[self setClientId:123 configuration:config];

NSArray<FlutterTextInputView*>* inputFields = self.installedInputViews;
FlutterTextInputView* inputView = inputFields[0];

XCTAssertTrue(inputView.isSecureTextEntry);

config = self.mutableTemplateCopy;
[config setValue:@"NO" forKey:@"obscureText"];
[self updateConfig:config];

XCTAssertFalse(inputView.isSecureTextEntry);
Copy link
Contributor

@cyanglaz cyanglaz Mar 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also test if [inputView reloadInputViews]; is called?

Copy link
Member Author

@LinXunFeng LinXunFeng Mar 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}

#pragma mark - TextEditingDelta tests
- (void)testTextEditingDeltasAreGeneratedOnTextInput {
FlutterTextInputView* inputView = [[FlutterTextInputView alloc] initWithOwner:textInputPlugin];
Expand Down