Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
d6d5695
Added golden image tests to impeller
gaaclarke Mar 16, 2023
b17819e
started writing a digest
gaaclarke Mar 20, 2023
345d019
added docstrings
gaaclarke Mar 20, 2023
93725ba
added harvester
gaaclarke Mar 20, 2023
aca9c66
updated readme
gaaclarke Mar 20, 2023
1ec9eb3
added logger wrapper
gaaclarke Mar 20, 2023
d079bd2
made the tests only run on mac
gaaclarke Mar 20, 2023
3141ca1
updated the run_tests.py script
gaaclarke Mar 22, 2023
f8c4431
added readme
gaaclarke Mar 22, 2023
0a6757f
made sure that the golden image tests are only compiled for mac
gaaclarke Mar 22, 2023
b881ff5
updated licenses
gaaclarke Mar 22, 2023
28ef8ff
lint fixes for run_tests.py
gaaclarke Mar 22, 2023
e9e796a
updated licenses again
gaaclarke Mar 22, 2023
9d902bb
more lints
gaaclarke Mar 22, 2023
e87078c
unused import
gaaclarke Mar 22, 2023
83c93fe
sorted imports
gaaclarke Mar 22, 2023
5735ac3
turned on the golden tests by default
gaaclarke Mar 22, 2023
1f863c9
fixed remote execution
gaaclarke Mar 22, 2023
3f00b5d
turned the tests off for the engine runs, going to specify it in the …
gaaclarke Mar 22, 2023
7d0058b
added goldctl dependency to "Mac host engine"
gaaclarke Mar 23, 2023
d0c5781
tried switching to engine_v2 to run the golden tests
gaaclarke Mar 23, 2023
386ddb4
tried adding the dependency to the drone
gaaclarke Mar 23, 2023
bfa2200
tried flipping the image in ciimage since it wasn't working when writ…
gaaclarke Mar 24, 2023
8267da7
switched to sending the filename to skia gold client, since the code …
gaaclarke Mar 24, 2023
79cc6fd
zach feedback 1
gaaclarke Mar 24, 2023
02b9f03
updated licenses golden
gaaclarke Mar 24, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
more lints
  • Loading branch information
gaaclarke committed Mar 24, 2023
commit 9d902bb13f365e0ebe36078aa85e4e0a4400a5dc
2 changes: 1 addition & 1 deletion impeller/golden_tests/working_directory.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ void WorkingDirectory::SetPath(const std::string& path) {
}

} // namespace testing
} // namespace impeller
} // namespace impeller
2 changes: 1 addition & 1 deletion impeller/golden_tests_harvester/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ dependency_overrides:
process:
path: ../../../third_party/pkg/process
typed_data:
path: ../../../third_party/dart/third_party/pkg/typed_data
path: ../../../third_party/dart/third_party/pkg/typed_data
6 changes: 4 additions & 2 deletions testing/run_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,16 @@
import glob
import multiprocessing
import os
from pathlib import Path
import platform
import re
import subprocess
import sys
import tempfile
import time
import xvfb

from pathlib import Path

SCRIPT_DIR = os.path.dirname(os.path.realpath(__file__))
BUILDROOT_DIR = os.path.abspath(
os.path.join(os.path.realpath(__file__), '..', '..', '..')
Expand Down Expand Up @@ -1008,7 +1010,7 @@ def run_impeller_golden_tests(build_dir: str):
with tempfile.TemporaryDirectory(prefix='impeller_golden') as temp_dir:
run_cmd([tests_path, '--working_dir=%s' % temp_dir])
with DirectoryChange(harvester_path):
bin_path = Path(".").joinpath('bin'
bin_path = Path('.').joinpath('bin'
).joinpath('golden_tests_harvester.dart')
run_cmd(['dart', 'run', str(bin_path), temp_dir])

Expand Down