This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add doc comment to Pipeline #40388
Merged
Add doc comment to Pipeline #40388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
approved these changes
Mar 17, 2023
justinmc
approved these changes
Mar 17, 2023
Contributor
justinmc
left a comment
justinmc
left a comment
There was a problem hiding this comment.
The doc comment makes sense to me as someone not familiar with this pipeline 👍 .
It might not be worth addressing this in these docs, but after reading this I don't know why or where we might use this pipeline.
Member
Author
|
@justinmc at present (unless someone's added another use) there's actually only a single use of this pipeline, which is the LayerTree pipeline used in the animator/rasterizer. Agreed it would probably be a little clearer if we just hardcoded that in rather than having a generic type, though the generic type sure makes this a lot easier to test :) I always feel a bit gross about adding "where this is used" type comments but given I don't see this changing anytime soon, maybe I should just add a breadcrumb. |
Adds more detailed documentation to the Pipeline class. Also fixes a typo in fml::Semaphore docs.
Member
Author
|
Done. |
Contributor
|
Sounds good. I agree about "where this is used" comments but the sentence you added seems pretty useful. Thanks! |
cbracken
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 17, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 18, 2023
* e6334f1 [web] Remove image codecs from Canvaskit Chromium (flutter/engine#40309) * 56727d6 Revert "[Impeller] mark decoded images as optimized for GPU access (#40356)" (flutter/engine#40387) * 2cd19e3 Wrap the iOS platform message handler in an autorelease pool block (flutter/engine#40373) * bab7853 Update analyzer for api_conform_test (flutter/engine#40386) * 87b2e82 Roll Fuchsia Mac SDK from z32cF6YFs6CvZbY3g... to 4ZrEK2uzGdp_Gz3DU... (flutter/engine#40385) * fc57995 Ignore some MTLCompiler failures in impeller unit tests (flutter/engine#40391) * 2398c52 Add doc comment to Pipeline (flutter/engine#40388) * f585d4b [macOS] Remove a single accessibility root assumption (flutter/engine#40316) * 940cf3c remove temporary flag and make FlutterTest the default font for real (flutter/engine#40352) * a1bf9fd drawTextBlob should not be compatible with opacity inheritance (flutter/engine#40396) * 55bf0d8 Use bundled analyzer everywhere (flutter/engine#40398) * 8e58041 Roll Skia from 9bfb45d3e065 to 49b902e5fb91 (11 revisions) (flutter/engine#40397) * 77c53d2 Default the CanvasKit base URL to local artifacts. (flutter/engine#40293) * 625ea53 Roll Skia from 49b902e5fb91 to aa983f5486f0 (7 revisions) (flutter/engine#40404) * 867679f [Impeller] Add playground flag to render for a specific amount of time. (flutter/engine#40377) * d741696 [Impeller] Remove unused bounds method from typographer interface (flutter/engine#40406) * 941323d Provisional iOS impeller flag flip (flutter/engine#40405) * bb971ab Revert "Default the CanvasKit base URL to local artifacts. (#40293)" (flutter/engine#40415)
zanderso
pushed a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds more detailed documentation to the Pipeline class. Also fixes a typo in fml::Semaphore docs.
No tests since this patch makes no semantic changes.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.