Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
a341b26
Add support for setting the heading level for web semantics (#97894)
victorgalo Apr 23, 2023
eff0206
Add support for setting the heading level for web semantics (#97894)
victorgalo Apr 24, 2023
7f8ef2c
Merge branch 'main' into add-semantics-heading-level
victorgalo Apr 24, 2023
9029d63
Add support for setting the heading level for web semantics (#97894)
victorgalo Apr 24, 2023
260d4bd
Add support for setting the heading level for web semantics (#97894)
victorgalo Apr 30, 2023
baea4c1
Merge branch 'main' into add-semantics-heading-level
victorgalo Apr 30, 2023
bf0fe7f
Merge branch 'main' into add-semantics-heading-level
victorgalo Sep 9, 2023
b773f81
Merge branch 'main' into add-semantics-heading-level
victorgalo Sep 9, 2023
90de9fc
Remove trailing spaces
victorgalo Sep 9, 2023
c9ac350
Merge branch 'main' into add-semantics-heading-level
victorgalo Sep 9, 2023
c8ccd31
Add export for new Heading role
victorgalo Sep 9, 2023
0241f07
Fix references for new Heading role
victorgalo Sep 10, 2023
6298a5f
Remove unused import
victorgalo Sep 10, 2023
36c5fd6
Fix PR comments (41435)
victorgalo Sep 19, 2023
30153e0
Remove trailing whitespace
victorgalo Sep 19, 2023
5460388
Add support for setting the heading level for web semantics (#97894)
victorgalo Sep 20, 2023
a526070
Add support for setting the heading level for web semantics (#97894)
victorgalo Sep 20, 2023
dceef3c
Add support for setting the heading level for web semantics (#97894)
victorgalo Sep 21, 2023
3a6e45d
Add support for setting the heading level for web semantics (#97894)
victorgalo Sep 24, 2023
b9bfb88
Add support for setting the heading level for web semantics (#97894)
victorgalo Sep 24, 2023
664c1e4
Change headingLevel to not be nullable
victorgalo Nov 12, 2023
e6a8c6a
Merge branch 'main' into add-semantics-heading-level
victorgalo Nov 12, 2023
470f67f
Change headingLevel to be non nullable
victorgalo Nov 12, 2023
a56c398
Change headingLevel to be non nullable
victorgalo Nov 12, 2023
b31bd9f
Change headingLevel to be non nullable
victorgalo Nov 12, 2023
8305e4b
Change headingLevel to be non nullable
victorgalo Nov 12, 2023
d860f21
Make headingLevel temporarily optional until framework part is uploaded
victorgalo Nov 13, 2023
a16a8f7
Merge branch 'main' into add-semantics-heading-level
victorgalo Nov 13, 2023
70efe89
Merge branch 'main' into add-semantics-heading-level
victorgalo Dec 2, 2023
ddeaefc
Change headingLevel to be non nullable
victorgalo Dec 4, 2023
bcd3205
remove trailing whitespaces
victorgalo Dec 4, 2023
9d25b32
Merge branch 'main' into add-semantics-heading-level
victorgalo Dec 4, 2023
268e31c
Change default value for headingLevel to 0
victorgalo Jan 19, 2024
a7bb630
Merge branch 'main' into add-semantics-heading-level
victorgalo Jan 19, 2024
0f72806
Change default value for headingLevel to 0
victorgalo Jan 21, 2024
79e4728
Add focusAsRouteDefault implementation to Heading primary role
victorgalo Jan 21, 2024
4b69d9f
Change default value for headingLevel to 0
victorgalo Jan 21, 2024
c83039b
Merge branch 'main' into add-semantics-heading-level
victorgalo Feb 11, 2024
b351c1e
Merge branch 'main' into add-semantics-heading-level
victorgalo Mar 13, 2024
5705912
Fix unit test for semantics heading level attribute
victorgalo Mar 13, 2024
89ef536
Merge branch 'main' into add-semantics-heading-level
victorgalo Mar 14, 2024
e60c0a7
Change constructor for Heading role
victorgalo Mar 14, 2024
bb787e0
Fix unit test for semantics heading level
victorgalo Mar 15, 2024
7199da1
Merge branch 'main' into add-semantics-heading-level
victorgalo Mar 15, 2024
76b65f6
Merge branch 'main' into add-semantics-heading-level
victorgalo Mar 15, 2024
ee38434
Merge branch 'main' into add-semantics-heading-level
victorgalo Mar 18, 2024
41f77aa
Merge branch 'main' into add-semantics-heading-level
victorgalo Mar 29, 2024
e38e3f3
Fix PR comments (41435)
victorgalo Sep 19, 2023
1e570fb
Change headingLevel to not be nullable
victorgalo Nov 12, 2023
ac1ec5e
Change default value for headingLevel to 0
victorgalo Jan 19, 2024
0b9efa6
Remove duplicated definition after fixing rebase conflicts
victorgalo Mar 29, 2024
4a54812
Merge branch 'main' into add-semantics-heading-level
victorgalo May 10, 2024
6d8d511
Remove unnecessary check for Heading primary role
victorgalo May 10, 2024
2586dbc
Merge branch 'main' into add-semantics-heading-level
victorgalo May 12, 2024
fc0a3a5
Merge branch 'main' into add-semantics-heading-level
chunhtai May 16, 2024
ca2d289
Remove duplicated case in switch statement
victorgalo May 17, 2024
5e05f24
Merge branch 'main' into add-semantics-heading-level
victorgalo May 17, 2024
9231840
Merge branch 'main' into add-semantics-heading-level
victorgalo May 17, 2024
c52b545
Merge branch 'main' into add-semantics-heading-level
victorgalo May 17, 2024
33a246c
Merge branch 'main' into add-semantics-heading-level
victorgalo May 18, 2024
1b0e241
Merge branch 'main' into add-semantics-heading-level
chunhtai May 29, 2024
e918e20
Merge branch 'main' into add-semantics-heading-level
victorgalo Jun 1, 2024
4383464
Change semantics headingLevel attribute to be not required until fram…
victorgalo Jun 1, 2024
5186055
fix lint
chunhtai Jun 4, 2024
af5e70a
Merge branch 'main' into add-semantics-heading-level
chunhtai Jun 4, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint
  • Loading branch information
chunhtai committed Jun 4, 2024
commit 518605585e3bece929d5b02c9430ce47a3a08bd0
2 changes: 0 additions & 2 deletions testing/scenario_app/lib/src/locale_initialization.dart
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ class LocaleInitialization extends Scenario {
childrenInTraversalOrder: Int32List(0),
childrenInHitTestOrder: Int32List(0),
additionalActions: Int32List(0),
headingLevel: 0,
);

final SemanticsUpdate semanticsUpdate = semanticsUpdateBuilder.build();
Expand Down Expand Up @@ -138,7 +137,6 @@ class LocaleInitialization extends Scenario {
childrenInTraversalOrder: Int32List(0),
childrenInHitTestOrder: Int32List(0),
additionalActions: Int32List(0),
headingLevel: 0,
);

final SemanticsUpdate semanticsUpdate = semanticsUpdateBuilder.build();
Expand Down