Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Only register top level window message listener upon registering service binding #41733

Merged
yaakovschectman merged 22 commits into from
May 10, 2023
Merged

Only register top level window message listener upon registering service binding #41733

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
a9edfd8
Listen for binding register
yaakovschectman May 4, 2023
248630a
Consume message on mac, linux
yaakovschectman May 4, 2023
4f72ae4
Fix typo
yaakovschectman May 4, 2023
d27058c
Fix typo
yaakovschectman May 4, 2023
3807362
Test service binding registration
yaakovschectman May 4, 2023
952520b
Formatting
yaakovschectman May 4, 2023
7dc998d
Comments
yaakovschectman May 4, 2023
559ab7b
Gate WM_CLOSE consumption
yaakovschectman May 4, 2023
748c3e5
Rename message
yaakovschectman May 4, 2023
2a7e68f
Update shell/platform/windows/flutter_windows_engine_unittests.cc
yaakovschectman May 4, 2023
ecadae4
Update shell/platform/windows/flutter_windows_engine_unittests.cc
yaakovschectman May 4, 2023
24a37cc
Feedback
yaakovschectman May 4, 2023
01409d4
TODO comments
yaakovschectman May 5, 2023
d35bf00
VS mistake
yaakovschectman May 5, 2023
47866e4
Tag gspencergoog in TODO for Linux
yaakovschectman May 5, 2023
a759f41
Tag chrome-bot
yaakovschectman May 5, 2023
621bca6
Rename method
yaakovschectman May 5, 2023
ff6af43
Rename var
yaakovschectman May 5, 2023
5368213
Cleanup null
yaakovschectman May 9, 2023
83d9d67
Formatting
yaakovschectman May 9, 2023
5047d74
Merge branch 'main' into wm_close_toplevel
yaakovschectman May 9, 2023
5e13448
Update TODO
yaakovschectman May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tag chrome-bot
  • Loading branch information
@yaakovschectman
yaakovschectman committed May 5, 2023
commit a759f41c81ba46c74618bb41772dcd37ee3d7acf
2 changes: 1 addition & 1 deletion shell/platform/darwin/macos/framework/Source/FlutterEngine.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,7 +1032,7 @@ - (void)handleMethodCall:(FlutterMethodCall*)call result:(FlutterResult)result {
} else if ([call.method isEqualToString:@"System.exitApplication"]) {
[[self terminationHandler] handleRequestAppExitMethodCall:call.arguments result:result];
} else if ([call.method isEqualToString:@"System.enableApplicationLifecycle"]) {
// TODO: Handle this message to enable exit message listening.
// TODO(chrome-bot): Handle this message to enable exit message listening.
Copy link
Member

@cbracken cbracken May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is chrome-bot something I don't yet know about or should this be gspencergoog?

Copy link
Contributor Author

@yaakovschectman yaakovschectman May 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chrome-bot was from the patch generated by the lint failure. It looks like no one is assigned to the open linux PR, but he authored it, so probably.

// https://github.com/flutter/flutter/issues/126033
result(nil);
} else {
Expand Down