Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Use new SkParagraph APIs for stroked text. #41735

Merged
auto-submit merged 5 commits into from
Jul 12, 2023
Merged

[Impeller] Use new SkParagraph APIs for stroked text. #41735

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d905708
[Impeller][WIP] Use new SkParagraph APIs for stroked text
May 4, 2023
a47bdc0
Merge branch 'main' of github.com:flutter/engine into stroked_text_12…
Jul 10, 2023
8a3a522
update
Jul 11, 2023
7831afd
Merge branch 'main' of github.com:flutter/engine into stroked_text_12…
Jul 11, 2023
ef55319
add test
Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add test
  • Loading branch information
jonahwilliams committed Jul 12, 2023
commit ef553198b24f16430d12fae0a62c9388e10846d2
13 changes: 13 additions & 0 deletions impeller/display_list/dl_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,19 @@ TEST_P(DisplayListTest, CanDrawWithMaskBlur) {
ASSERT_TRUE(OpenPlaygroundHere(builder.Build()));
}

TEST_P(DisplayListTest, CanDrawStrokedText) {
flutter::DisplayListBuilder builder;
flutter::DlPaint paint;

paint.setDrawStyle(flutter::DlDrawStyle::kStroke);
paint.setColor(flutter::DlColor::kRed());
builder.DrawTextBlob(
SkTextBlob::MakeFromString("stoked about stroked text", CreateTestFont()),
250, 250, paint);

ASSERT_TRUE(OpenPlaygroundHere(builder.Build()));
}

TEST_P(DisplayListTest, IgnoreMaskFilterWhenSavingLayer) {
auto texture = CreateTextureForFixture("embarcadero.jpg");
flutter::DisplayListBuilder builder;
Expand Down
1 change: 0 additions & 1 deletion impeller/typographer/backends/skia/text_frame_skia.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
#pragma once

#include "flutter/fml/macros.h"
#include "impeller/geometry/path.h"
#include "impeller/typographer/text_frame.h"
#include "third_party/skia/include/core/SkTextBlob.h"

Expand Down