Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
++
  • Loading branch information
Jonah Williams committed Jul 3, 2023
commit 24fca1c006b5569a7b2d95b6f04bd820c6e650a5
2 changes: 1 addition & 1 deletion shell/platform/embedder/embedder_surface_gl_impeller.cc
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ EmbedderSurfaceGLImpeller::EmbedderSurfaceGLImpeller(
fbo_reset_after_present_(fbo_reset_after_present),
external_view_embedder_(std::move(external_view_embedder)),
worker_(std::make_shared<ReactorWorker>()) {
worker_->SetReactionsAllowedOnCurrentThread(true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: should this be further down after the early returns?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

// Make sure all required members of the dispatch table are checked.
if (!gl_dispatch_table_.gl_make_current_callback ||
!gl_dispatch_table_.gl_clear_current_callback ||
Expand Down Expand Up @@ -87,7 +88,6 @@ EmbedderSurfaceGLImpeller::EmbedderSurfaceGLImpeller(
}

FML_LOG(ERROR) << "Using the Impeller rendering backend (GLES/ANGLE).";
worker_->SetReactionsAllowedOnCurrentThread(true);
valid_ = true;
}

Expand Down
2 changes: 1 addition & 1 deletion shell/platform/windows/angle_surface_manager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ bool AngleSurfaceManager::Initialize() {
const EGLint config_attributes[] = {EGL_RED_SIZE, 8, EGL_GREEN_SIZE, 8,
EGL_BLUE_SIZE, 8, EGL_ALPHA_SIZE, 8,
EGL_DEPTH_SIZE, 8, EGL_STENCIL_SIZE, 8,
EGL_SAMPLES, 4};
EGL_NONE};

const EGLint display_context_attributes[] = {EGL_CONTEXT_CLIENT_VERSION, 2,
EGL_NONE};
Expand Down