Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Allocate buffers out of a pool on the raster thread. #43564

Merged
auto-submit merged 9 commits into from
Jul 12, 2023
Merged

[Impeller] Allocate buffers out of a pool on the raster thread. #43564

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8590d30
[Impeller] allocate buffers out of a pool on the raster thread.
Jul 11, 2023
866761f
fall back to host visible only
Jul 11, 2023
1a01926
wip testing
Jul 11, 2023
c85a337
testing
Jul 11, 2023
3947f81
++
Jul 11, 2023
b8bee47
++
Jul 11, 2023
9d4d44a
++
Jul 11, 2023
4efb6a8
use context didAcquireSurfaceFrame
Jul 12, 2023
10d29cc
use c++ types
Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
++
  • Loading branch information
jonahwilliams committed Jul 11, 2023
commit 9d4d44a1626df192a2822c498c578fc33249baa9
2 changes: 0 additions & 2 deletions impeller/renderer/backend/vulkan/allocator_vk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -495,7 +495,6 @@ bool AllocatorVK::CreateBufferPool(VmaAllocator allocator, VmaPool* pool) {
auto result = vk::Result{vmaFindMemoryTypeIndexForBufferInfo(
allocator, &buffer_info_native, &allocation_info, &memTypeIndex)};
if (result != vk::Result::eSuccess) {
VALIDATION_LOG << "Could not find memory type for buffer pool.";
return false;
}

Expand All @@ -506,7 +505,6 @@ bool AllocatorVK::CreateBufferPool(VmaAllocator allocator, VmaPool* pool) {

result = vk::Result{vmaCreatePool(allocator, &pool_create_info, pool)};
Copy link
Member

@chinmaygarde chinmaygarde Jul 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pools, allocators, and allocations are getting pervasive enough that not having RAII wrappers is getting hard to reason about. In this patch or another if you prefer, can we wrap these in fml::UniqueObject please?

Copy link
Contributor Author

@jonahwilliams jonahwilliams Jul 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I could make one for the allocator, but the pools also need an allocator for disposal and it doesn't look like fml::UniqueObject supports a userdata like ptr I could use for that. Is that a reasonable update you could make to support disposing pools?

if (result != vk::Result::eSuccess) {
VALIDATION_LOG << "Could not create buffer pool.";
return false;
}
return true;
Expand Down