Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Provide convenient default factories for platform views #43828

Merged
auto-submit merged 6 commits into from
Jul 26, 2023
Merged

[web] Provide convenient default factories for platform views #43828

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
44b63ca
[web] Provide convenient default factories for platform views
mdebbar Jul 19, 2023
7c2f6f7
Merge branch 'main' into default_factories
mdebbar Jul 20, 2023
3d183ae
move view types to dart:ui_web
mdebbar Jul 25, 2023
44ffc05
remove unnecessary extension
mdebbar Jul 25, 2023
f71dbab
Merge branch 'main' into default_factories
mdebbar Jul 25, 2023
ad3774e
make constants into statics on PlatformViewRegistry
mdebbar Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove unnecessary extension
  • Loading branch information
@mdebbar
mdebbar committed Jul 25, 2023
commit 44ffc05c453d02252f88d022292844783e561167
10 changes: 2 additions & 8 deletions lib/web_ui/lib/src/engine/platform_views/content_manager.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,12 +242,6 @@ DomElement _defaultFactory(
Object? params,
}) {
params!;
params as _DefaultFactoryParams;
return domDocument.createElement(params.tagName);
}

typedef _DefaultFactoryParams = Map<Object?, Object?>;

extension on _DefaultFactoryParams {
String get tagName => this['tagName']! as String;
params as Map<Object?, Object?>;
return domDocument.createElement(params.readString('tagName'));
}