Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Reland "Remove more calls to SkCanvas::flush() and SkSurface::flush()" #43965

Merged
kjlubick merged 4 commits into from
Jul 25, 2023
Merged

Reland "Remove more calls to SkCanvas::flush() and SkSurface::flush()" #43965

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e3d139
Reland "remove more calls to SkCanvas::flush() and SkSurface::flush()"
kjlubick Jul 24, 2023
f588005
flush and submit context also
kjlubick Jul 24, 2023
f35ad3f
remove extra returns
kjlubick Jul 24, 2023
981e2cd
remove more returns
kjlubick Jul 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
remove more returns
  • Loading branch information
@kjlubick
kjlubick committed Jul 24, 2023
commit 981e2cd2d7029b310ba5bc84cec0b72d7d6d94a5
6 changes: 2 additions & 4 deletions display_list/testing/dl_rendering_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4259,8 +4259,7 @@ class DisplayListNopTest : public DisplayListCanvas {
if (GrDirectContext* direct_context = GrAsDirectContext(
result_surface->sk_surface()->recordingContext())) {
direct_context->flushAndSubmit();
return direct_context->flushAndSubmit(result_surface->sk_surface(),
true);
direct_context->flushAndSubmit(result_surface->sk_surface(), true);
}
auto result_pixels =
std::make_unique<RenderResult>(result_surface->sk_surface());
Expand Down Expand Up @@ -4321,8 +4320,7 @@ class DisplayListNopTest : public DisplayListCanvas {
if (GrDirectContext* direct_context = GrAsDirectContext(
result_surface->sk_surface()->recordingContext())) {
direct_context->flushAndSubmit();
return direct_context->flushAndSubmit(result_surface->sk_surface(),
true);
direct_context->flushAndSubmit(result_surface->sk_surface(), true);
}
auto result_pixels =
std::make_unique<RenderResult>(result_surface->sk_surface());
Expand Down