Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Replace Vulkan rotation checks with polling #44361

Merged
matanlurey merged 9 commits into from
Aug 10, 2023
Merged

[Impeller] Replace Vulkan rotation checks with polling #44361

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7cc21c2
Revert "[Impeller] Treat SubOptimalKHR as rotated. (#43214)"
matanlurey Aug 3, 2023
b6b22e3
Merge remote-tracking branch 'upstream/main' into vulkan-orientation-…
matanlurey Aug 8, 2023
5cf8477
Update malioc.
matanlurey Aug 8, 2023
af80ca9
Revert "Update malioc."
matanlurey Aug 8, 2023
7fcdb7f
Implement polling per-frame.
matanlurey Aug 8, 2023
5113140
Tweak switch case.
matanlurey Aug 8, 2023
d23b8b6
Add comment.
matanlurey Aug 8, 2023
e7c0448
Merge remote-tracking branch 'upstream/main' into vulkan-orientation-…
matanlurey Aug 8, 2023
5690f1f
Tweak message.
matanlurey Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tweak switch case.
  • Loading branch information
@matanlurey
matanlurey committed Aug 8, 2023
commit 5113140042a136535b41a8c6870f86901ffbefa9
5 changes: 5 additions & 0 deletions impeller/renderer/backend/vulkan/swapchain_impl_vk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,6 +486,11 @@ bool SwapchainImplVK::Present(const std::shared_ptr<SwapchainImageVK>& image,
// Vulkan guarantees that the set of queue operations will still
// complete successfully.
[[fallthrough]];
case vk::Result::eSuboptimalKHR:
// In theory we shouldn't receive this (because we're polling above)
// but we shouldn't handle it as a validation error if we do receive
// it.
[[fallthrough]];
case vk::Result::eSuccess:
return;
default:
Expand Down