Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Android a11y bridge sets importantness #44452

Merged
auto-submit merged 9 commits into from
Aug 9, 2023
Merged

Android a11y bridge sets importantness #44452

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7d0eaa6
Android a11y bridge sets importantness
chunhtai Aug 7, 2023
f1c9ea4
update
chunhtai Aug 7, 2023
c10dbde
format
chunhtai Aug 7, 2023
9ee7c31
update
chunhtai Aug 7, 2023
16a9312
Update shell/platform/android/io/flutter/view/AccessibilityBridge.java
chunhtai Aug 8, 2023
a6ec086
Update shell/platform/android/io/flutter/view/AccessibilityBridge.java
chunhtai Aug 8, 2023
5352976
Apply suggestions from code review
chunhtai Aug 8, 2023
5143286
Merge branch 'main' into a11y-scanner
chunhtai Aug 9, 2023
50d6b02
format
chunhtai Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
  • Loading branch information
@chunhtai
chunhtai committed Aug 7, 2023
commit f1c9ea43822454cbde533e7dd58ed4d3a25a6151
8 changes: 4 additions & 4 deletions shell/platform/android/io/flutter/view/AccessibilityBridge.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
import io.flutter.util.Predicate;
import io.flutter.util.ViewUtils;
import io.flutter.view.AccessibilityBridge.Flag;

import java.nio.ByteBuffer;
import java.nio.ByteOrder;
import java.nio.charset.Charset;
Expand Down Expand Up @@ -2170,9 +2169,10 @@ public enum Action {
}

// Actions that are triggered by Android OS, as oppsite to user-triggered actions.
Copy link

@Logharaa Logharaa Aug 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: typo at 'oppsite'

static int systemAction = Action.DID_GAIN_ACCESSIBILITY_FOCUS.value &
Action.DID_LOSE_ACCESSIBILITY_FOCUS.value &
Action.SHOW_ON_SCREEN.value;
static int systemAction =
Action.DID_GAIN_ACCESSIBILITY_FOCUS.value
& Action.DID_LOSE_ACCESSIBILITY_FOCUS.value
& Action.SHOW_ON_SCREEN.value;

// Must match SemanticsFlag in semantics.dart
// https://github.com/flutter/engine/blob/main/lib/ui/semantics.dart
Expand Down
3 changes: 1 addition & 2 deletions shell/platform/android/test/io/flutter/view/AccessibilityBridgeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,8 +344,7 @@ public void itSetsRootViewNotImportantForAccessibility() {
AccessibilityBridge spyAccessibilityBridge = spy(accessibilityBridge);
AccessibilityNodeInfo mockNodeInfo = mock(AccessibilityNodeInfo.class);

when(spyAccessibilityBridge.obtainAccessibilityNodeInfo(mockRootView))
.thenReturn(mockNodeInfo);
when(spyAccessibilityBridge.obtainAccessibilityNodeInfo(mockRootView)).thenReturn(mockNodeInfo);
spyAccessibilityBridge.createAccessibilityNodeInfo(View.NO_ID);
verify(mockNodeInfo, times(1)).setImportantForAccessibility(eq(false));
}
Expand Down