Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
106 commits
Select commit Hold shift + click to select a range
d36a55d
Rebase
dkwingsmt Jun 30, 2023
3812621
Rename vars and fix fuchsia compile
dkwingsmt Jun 30, 2023
b1b68eb
Revert window metric changes
dkwingsmt Jul 5, 2023
5e036d8
Apply suggestions from code review
dkwingsmt Jul 6, 2023
ba42c07
Merge remote-tracking branch 'origin/main' into mv-window-metrics
dkwingsmt Jul 6, 2023
fba2c7c
Doc enable_implicit_view
dkwingsmt Jul 6, 2023
d7c6510
Better platConfig structure for adding window
dkwingsmt Jul 6, 2023
968c7e9
Merge remote-tracking branch 'origin/main' into mv-window-metrics
dkwingsmt Jul 10, 2023
752a0a4
Merge remote-tracking branch 'origin/main' into mv-window-metrics
dkwingsmt Jul 10, 2023
c912775
Merge remote-tracking branch 'origin/main' into mv-window-metrics
dkwingsmt Jul 20, 2023
2a87664
Fix compile
dkwingsmt Jul 23, 2023
adf5b8f
Doc for implicit view
dkwingsmt Jul 23, 2023
f1a497b
Two tests
dkwingsmt Jul 24, 2023
f31f60c
Remove platform data view metrics
dkwingsmt Jul 24, 2023
9d68f3c
Extract function
dkwingsmt Jul 24, 2023
7af9496
Docs and address comments
dkwingsmt Jul 24, 2023
2e539c6
One more sentence
dkwingsmt Jul 24, 2023
d20363e
Merge remote-tracking branch 'origin/main' into mv-window-metrics
dkwingsmt Jul 24, 2023
3d5a190
AddRemoveView test
dkwingsmt Jul 25, 2023
ba845c7
Merge remote-tracking branch 'origin/main' into mv-window-metrics
dkwingsmt Jul 25, 2023
4fc4922
Remove expected size on removal
dkwingsmt Jul 25, 2023
db9a99c
More docs
dkwingsmt Jul 25, 2023
a098175
Merge remote-tracking branch 'origin/main' into mv-window-metrics
dkwingsmt Jul 25, 2023
2128688
Assign viewId not bool. Move viewId to settings.h.
dkwingsmt Jul 25, 2023
4f049cd
Remove more implicit view ID
dkwingsmt Jul 25, 2023
c795035
Fix compile, prefix view id with flutter
dkwingsmt Jul 25, 2023
03520e2
Address many comments
dkwingsmt Jul 26, 2023
285c0f6
Correct FlushRuntimeStateToIsolate and PlatformData
dkwingsmt Jul 27, 2023
9c92de2
AddView specifies view config
dkwingsmt Jul 27, 2023
86bd921
Merge remote-tracking branch 'origin/main' into mv-window-metrics
dkwingsmt Jul 27, 2023
a898834
Remove ImplicitViewEnabled from more and lint
dkwingsmt Jul 27, 2023
2ff8609
Fix test and lint
dkwingsmt Jul 28, 2023
c61cf67
Fix tests?
dkwingsmt Jul 31, 2023
d9fc2a5
Shell Add/RemoveView blocking
dkwingsmt Aug 1, 2023
e99900a
Merge remote-tracking branch 'origin/main' into mv-window-metrics
dkwingsmt Aug 1, 2023
89755d2
Implement Rasterizer::CollectView
dkwingsmt Aug 1, 2023
42db5c3
Flushing test
dkwingsmt Aug 1, 2023
164ca90
Add TODO doc
dkwingsmt Aug 1, 2023
3e2902b
doc for implicit view ID.
dkwingsmt Aug 1, 2023
26d3cbe
Better doc
dkwingsmt Aug 1, 2023
8db91df
Bring back docs
dkwingsmt Aug 1, 2023
8d718d5
Merge remote-tracking branch 'origin/main' into mv-window-metrics
dkwingsmt Aug 1, 2023
0d3f6fb
Merge remote-tracking branch 'origin/main' into mv-window-metrics
dkwingsmt Aug 1, 2023
5cb56f8
Trivial comments
dkwingsmt Aug 3, 2023
6264164
Use TODO issue; solve lint
dkwingsmt Aug 3, 2023
a1b0740
Simplify implicit view init, add assertion
dkwingsmt Aug 4, 2023
b3284aa
Doc
dkwingsmt Aug 4, 2023
a7e033b
WIP
dkwingsmt Aug 4, 2023
2fb045b
Comments
dkwingsmt Aug 4, 2023
257f7cc
Merge remote-tracking branch 'origin/main' into mv-window-metrics
dkwingsmt Aug 4, 2023
9bb1d75
RemoveView no longer blocks
dkwingsmt Aug 4, 2023
90020f4
Fix compile
dkwingsmt Aug 5, 2023
ed46975
Compilable
dkwingsmt Aug 7, 2023
eb00183
Merge remote-tracking branch 'origin/main' into mv-pipeline
dkwingsmt Aug 7, 2023
7c24ab8
Merge remote-tracking branch 'origin/main' into mv-window-metrics
dkwingsmt Aug 7, 2023
4e2d39a
Merge branch 'mv-window-metrics' into mv-pipeline
dkwingsmt Aug 7, 2023
a3b7567
Merge remote-tracking branch 'origin/main' into mv-pipeline
dkwingsmt Aug 11, 2023
5c7c313
Merge remote-tracking branch 'origin/main' into mv-pipeline
dkwingsmt Aug 15, 2023
9b6210e
Merge remote-tracking branch 'origin/main' into mv-pipeline
dkwingsmt Aug 31, 2023
9c888ec
Clear changes
dkwingsmt Aug 31, 2023
8d14e6d
More clear patch
dkwingsmt Aug 31, 2023
29aea0a
lint
dkwingsmt Sep 2, 2023
3f17841
Merge remote-tracking branch 'dkwingsmt/mv-pipeline' into mv-pipeline
dkwingsmt Sep 5, 2023
6589d45
Merge remote-tracking branch 'origin/main' into mv-pipeline
dkwingsmt Sep 5, 2023
a762a11
Merge remote-tracking branch 'origin/main' into mv-pipeline
dkwingsmt Sep 5, 2023
2bead3f
Merge remote-tracking branch 'origin/main' into mv-pipeline
dkwingsmt Sep 22, 2023
50b7031
Merge changes with mv-rasterizer
dkwingsmt Sep 22, 2023
f08c963
Remove unneeded include
dkwingsmt Sep 22, 2023
87c73c4
Merge remote-tracking branch 'origin/main' into mv-pipeline
dkwingsmt Sep 29, 2023
2a5a715
Merge remote-tracking branch 'origin/main' into mv-pipeline
dkwingsmt Oct 4, 2023
b74574b
assert frame_timings_recorder is not null in render
dkwingsmt Oct 4, 2023
a705321
Fix many shell tests
dkwingsmt Oct 6, 2023
7f7d0ad
Merge remote-tracking branch 'origin/main' into mv-pipeline
dkwingsmt Oct 6, 2023
a0dd49a
Refactor PumpOneFrame
dkwingsmt Oct 7, 2023
629ea33
Fix lint
dkwingsmt Oct 8, 2023
02ba1b9
Doc, and logs
dkwingsmt Oct 8, 2023
29972e0
Add debug logs
dkwingsmt Oct 8, 2023
dfbd19e
Wait for 2 frames
dkwingsmt Oct 9, 2023
b792ff7
Add more logs
dkwingsmt Oct 9, 2023
be6804b
Fix
dkwingsmt Oct 9, 2023
25cf6f5
Fix two more tests
dkwingsmt Oct 9, 2023
34bf49a
Merge remote-tracking branch 'origin/main' into mv-pipeline
dkwingsmt Oct 9, 2023
0c2f053
Fix compile
dkwingsmt Oct 9, 2023
862a318
Remove logs
dkwingsmt Oct 9, 2023
56cd636
Better fix secondary vsync test
dkwingsmt Oct 9, 2023
1f411ec
Run engine for the first time
dkwingsmt Oct 9, 2023
6cec636
Test complete
dkwingsmt Oct 10, 2023
8021575
Remove postsync
dkwingsmt Oct 10, 2023
ae3e06e
Add docs and fix a lint
dkwingsmt Oct 10, 2023
b037f9a
Add log
dkwingsmt Oct 10, 2023
4f34de0
Fix compile
dkwingsmt Oct 10, 2023
1b21cea
Use another way to fix secondary vsync test
dkwingsmt Oct 10, 2023
181a94b
Fix lint
dkwingsmt Oct 10, 2023
3523e91
Double test started
dkwingsmt Oct 10, 2023
e7bd8fe
Merge remote-tracking branch 'origin/main' into mv-pipeline
dkwingsmt Oct 10, 2023
7a1436d
Fix lint
dkwingsmt Oct 10, 2023
918cf19
Pretty string state
dkwingsmt Oct 12, 2023
199ff4a
EngineContext
dkwingsmt Oct 16, 2023
55b57b2
Remove some params
dkwingsmt Oct 16, 2023
9544da9
Move to engine test
dkwingsmt Oct 16, 2023
4c9a11a
Move mock up
dkwingsmt Oct 16, 2023
39dfbc6
Verify view ID
dkwingsmt Oct 16, 2023
fc44a61
Merge remote-tracking branch 'origin/main' into mv-pipeline
dkwingsmt Oct 19, 2023
d52f4f6
Fix some lint
dkwingsmt Oct 19, 2023
3a9cfb1
Fix clang tidy
dkwingsmt Oct 19, 2023
d570066
Fix test
dkwingsmt Oct 20, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bring back docs
  • Loading branch information
dkwingsmt committed Aug 1, 2023
commit 8db91df2e89471d809772df5698249dcb44a148f
7 changes: 4 additions & 3 deletions lib/ui/window/platform_configuration.h
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,9 @@ class PlatformConfiguration final {
//----------------------------------------------------------------------------
/// @brief Notify the framework that a new view is available.
///
/// The implicit view should also be added with this method.
/// A view must be added before other methods can refer to it,
/// including the implicit view. Adding a view that has been
/// added triggers assertion.
///
/// @param[in] view_id The ID of the new view.
/// @param[in] viewport_metrics The initial viewport metrics for the view.
Expand All @@ -271,8 +273,7 @@ class PlatformConfiguration final {
//----------------------------------------------------------------------------
/// @brief Notify the framework that a view is no longer available.
///
/// The implicit view should not be removed with this method,
/// since it should never be removed.
/// Removing a view that has not been added triggers assertion.
///
/// @param[in] view_id The ID of the view.
///
Expand Down
7 changes: 4 additions & 3 deletions runtime/runtime_controller.h
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,9 @@ class RuntimeController : public PlatformConfigurationClient {
//----------------------------------------------------------------------------
/// @brief Notify the isolate that a new view is available.
///
/// The implicit view should also be added with this method.
/// A view must be added before other methods can refer to it,
/// including the implicit view. Adding a view that has been
/// added triggers assertion.
///
/// @param[in] view_id The ID of the new view.
/// @param[in] viewport_metrics The initial viewport metrics for the view.
Expand All @@ -176,8 +178,7 @@ class RuntimeController : public PlatformConfigurationClient {
//----------------------------------------------------------------------------
/// @brief Notify the isolate that a view is no longer available.
///
/// The implicit view should not be removed with this method,
/// since it should never be removed.
/// Removing a view that has not been added triggers assertion.
///
/// @param[in] view_id The ID of the view.
///
Expand Down
8 changes: 5 additions & 3 deletions shell/common/engine.h
Original file line number Diff line number Diff line change
Expand Up @@ -678,7 +678,9 @@ class Engine final : public RuntimeDelegate, PointerDataDispatcher::Delegate {
//----------------------------------------------------------------------------
/// @brief Notify the Flutter application that a new view is available.
///
/// The implicit view should also be added with this method.
/// A view must be added before other methods can refer to it,
/// including the implicit view. Adding a view that has been
/// added triggers assertion.
///
/// @param[in] view_id The ID of the new view.
/// @param[in] viewport_metrics The initial viewport metrics for the view.
Expand All @@ -689,8 +691,8 @@ class Engine final : public RuntimeDelegate, PointerDataDispatcher::Delegate {
/// @brief Notify the Flutter application that a view is no
/// longer available.
///
/// The implicit view should not be removed with this method,
/// since it should never be removed.
/// Removing a view that has not been not added triggers
/// assertion.
///
/// @param[in] view_id The ID of the view.
///
Expand Down
5 changes: 3 additions & 2 deletions shell/common/rasterizer.h
Original file line number Diff line number Diff line change
Expand Up @@ -209,8 +209,9 @@ class Rasterizer final : public SnapshotDelegate,
///
/// This method should be called a view is removed.
///
/// Resources for a view is allocated the first time the
/// rasterizer encouters this view ID.
/// The rasterizer don't need views to be registered. Last-frame
/// states for views are recorded when layer trees are rasterized
/// to the view and used during `Rasterizer::DrawLastLayerTree`.
///
/// @param[in] view_id The ID of the view.
///
Expand Down
17 changes: 9 additions & 8 deletions shell/common/shell.h
Original file line number Diff line number Diff line change
Expand Up @@ -298,12 +298,13 @@ class Shell final : public PlatformView::Delegate,
///
bool IsSetup() const;

/// @brief Adds a non-implicit view.
/// @brief Allocates resources for a new non-implicit view.
///
/// This method returns immediately and does not wait for the tasks
/// on the UI thread to finish. This is because operations are either
/// initiated from the UI thread (such as rendering), or are sent as a
/// posted task that is queued.
/// This method returns immediately and does not wait for the tasks on
/// the UI thread to finish. This is safe because operations are
/// either initiated from the UI thread (such as rendering), or are
/// sent as posted tasks that are queued. In either case, it's ok for
/// the engine to have views that the Dart VM doesn't.
///
/// The implicit view should never be added with this function.
/// Instead, it is added internally on Shell initialization depending
Expand All @@ -315,10 +316,10 @@ class Shell final : public PlatformView::Delegate,
///
void AddView(int64_t view_id, const ViewportMetrics& viewport_metrics);

/// @brief Removes a non-implicit view.
/// @brief Deallocates resources for a non-implicit view.
///
/// This method waits for the tasks on the rasterizer thread and the
/// UI thread to finish before returning.
/// This method waits for the tasks on the UI thread to finish before
/// returning.
///
/// The implicit view should never be removed. Trying to remove
/// `kFlutterImplicitViewId` is a no-op with warning.
Expand Down