Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
bf3c3c7
Skeleton cpp function
yaakovschectman Aug 16, 2023
839f8d1
Calling
yaakovschectman Aug 16, 2023
5dd476e
Message makes it to Shell
yaakovschectman Aug 16, 2023
0bdacd0
Part of project args
yaakovschectman Aug 16, 2023
c2091cf
FlutterWindowsEngine creates a callback
yaakovschectman Aug 16, 2023
b3cf373
Engine listens
yaakovschectman Aug 17, 2023
0ca00f7
Remove OnApplicationLifecycleEnabled
yaakovschectman Aug 17, 2023
0ea137c
Unit test
yaakovschectman Aug 17, 2023
af8cf2d
Doc comments
yaakovschectman Aug 17, 2023
711ebac
Formatting
yaakovschectman Aug 17, 2023
17c85e1
Update to info struct
yaakovschectman Aug 18, 2023
770bcfe
Merge branch 'main' into embedder_channel
yaakovschectman Aug 18, 2023
da9083a
Update test
yaakovschectman Aug 18, 2023
ba08343
Merge branch 'main' into embedder_channel
yaakovschectman Aug 21, 2023
f10ec72
Web parity
yaakovschectman Aug 21, 2023
6d86f71
Add callback to test context
yaakovschectman Aug 21, 2023
c7a6454
Start unit test
yaakovschectman Aug 23, 2023
6286c00
Merge branch 'main' into embedder_channel
yaakovschectman Aug 23, 2023
60f5ac9
Merge branch 'main' into embedder_channel
yaakovschectman Aug 23, 2023
d136a93
Run expired tasks
yaakovschectman Aug 23, 2023
3413635
Rename methods
yaakovschectman Aug 24, 2023
ff1e6c2
Copy channel name in lambda
yaakovschectman Aug 24, 2023
bf67370
Merge branch 'main' into embedder_channel
yaakovschectman Aug 24, 2023
6cf7338
Meet mac tidy
yaakovschectman Aug 24, 2023
f0ac397
Required named param
yaakovschectman Aug 24, 2023
bff347a
Check for listener set
yaakovschectman Aug 24, 2023
2e87fa9
Check values in unittest
yaakovschectman Aug 24, 2023
cf671c8
PR feedback
yaakovschectman Aug 24, 2023
77316c9
Merge branch 'main' into embedder_channel
yaakovschectman Aug 24, 2023
54d0826
Merge branch 'main' into embedder_channel
yaakovschectman Aug 28, 2023
62b015c
Remove const reference
yaakovschectman Aug 28, 2023
478b6dd
STREQ
yaakovschectman Aug 28, 2023
96e841c
Test lifecycle begins
yaakovschectman Aug 28, 2023
d01b399
Test lifecycle begins
yaakovschectman Aug 28, 2023
48a17ff
Update shell/platform/embedder/tests/embedder_unittests.cc
yaakovschectman Aug 28, 2023
6b9b572
Update shell/common/platform_view.h
yaakovschectman Aug 28, 2023
5b6a221
Merge branch 'main' into embedder_channel
yaakovschectman Aug 28, 2023
bdbb829
Add struct size
yaakovschectman Aug 28, 2023
f4d292b
Reintroduce const ref
yaakovschectman Aug 29, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Copy channel name in lambda
  • Loading branch information
yaakovschectman committed Aug 24, 2023
commit ff1e6c271b3c205d0db7948a10fc6f5bc263a2c3
2 changes: 1 addition & 1 deletion shell/common/shell.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1333,7 +1333,7 @@ void Shell::OnEngineChannelUpdate(const std::string& name, bool listening) {
FML_DCHECK(task_runners_.GetUITaskRunner()->RunsTasksOnCurrentThread());

task_runners_.GetPlatformTaskRunner()->PostTask(
[view = platform_view_->GetWeakPtr(), name, listening] {
[view = platform_view_->GetWeakPtr(), name = std::move(name), listening] {
if (view) {
view->SendChannelUpdate(name, listening);
}
Expand Down