[Impeller] transform text path offsets so color sources match expected offsets for gradients.

impeller/display_list/dl_dispatcher.cc

@@ -1118,12 +1118,10 @@ void DlDispatcher::drawTextBlob(const sk_sp<SkTextBlob>& blob,
   const auto text_frame = maybe_text_frame.value();
   if (paint_.style == Paint::Style::kStroke ||
       paint_.color_source.GetType() != ColorSource::Type::kColor) {
-    auto path = skia_conversions::PathDataFromTextBlob(blob);
     auto bounds = blob->bounds();
-    canvas_.Save();
-    canvas_.Translate({x + bounds.left(), y + bounds.top(), 0.0});
+    auto path = skia_conversions::PathDataFromTextBlob(blob);
+    path.Shift(Point(x + bounds.left(), y + bounds.top()));
     canvas_.DrawPath(path, paint_);
-    canvas_.Restore();
     return;
   }
 

impeller/geometry/geometry_unittests.cc

@@ -2373,6 +2373,42 @@ TEST(GeometryTest, HalfConversions) {
 #endif  // FML_OS_WIN
 }
 
+TEST(GeometryTest, PathShifting) {
+  PathBuilder builder{};
+  auto path =
+      builder.AddLine(Point(0, 0), Point(10, 10))
+          .AddQuadraticCurve(Point(10, 10), Point(15, 15), Point(20, 20))
+          .AddCubicCurve(Point(20, 20), Point(25, 25), Point(-5, -5),
+                         Point(30, 30))
+          .Close()
+          .TakePath();
+  path.Shift(Point(1, 1));
+
+  ContourComponent contour;
+  LinearPathComponent linear;
+  QuadraticPathComponent quad;
+  CubicPathComponent cubic;
+
+  ASSERT_TRUE(path.GetContourComponentAtIndex(0, contour));
+  ASSERT_TRUE(path.GetLinearComponentAtIndex(1, linear));
+  ASSERT_TRUE(path.GetQuadraticComponentAtIndex(3, quad));
+  ASSERT_TRUE(path.GetCubicComponentAtIndex(5, cubic));
+
+  ASSERT_EQ(contour.destination, Point(1, 1));
+
+  ASSERT_EQ(linear.p1, Point(1, 1));
+  ASSERT_EQ(linear.p2, Point(11, 11));
+
+  ASSERT_EQ(quad.cp, Point(16, 16));
+  ASSERT_EQ(quad.p1, Point(11, 11));
+  ASSERT_EQ(quad.p2, Point(21, 21));
+
+  ASSERT_EQ(cubic.cp1, Point(26, 26));
+  ASSERT_EQ(cubic.cp2, Point(-4, -4));
+  ASSERT_EQ(cubic.p1, Point(21, 21));
+  ASSERT_EQ(cubic.p2, Point(31, 31));
+}
+
 }  // namespace testing
 }  // namespace impeller
 

impeller/geometry/path.cc

@@ -61,6 +61,33 @@ void Path::SetConvexity(Convexity value) {
   convexity_ = value;
 }
 
+void Path::Shift(Point shift) {
+  size_t currentIndex = 0;
+  for (const auto& component : components_) {
+    switch (component.type) {
+      case ComponentType::kLinear:
+        linears_[component.index].p1 += shift;
+        linears_[component.index].p2 += shift;
+        break;
+      case ComponentType::kQuadratic:
+        quads_[component.index].cp += shift;
+        quads_[component.index].p1 += shift;
+        quads_[component.index].p2 += shift;
+        break;
+      case ComponentType::kCubic:
+        cubics_[component.index].cp1 += shift;
+        cubics_[component.index].cp2 += shift;
+        cubics_[component.index].p1 += shift;
+        cubics_[component.index].p2 += shift;
+        break;
+      case ComponentType::kContour:
+        contours_[component.index].destination += shift;
+        break;
+    }
+    currentIndex++;
+  }
+}
+
 Path& Path::AddLinearComponent(Point p1, Point p2) {
   linears_.emplace_back(p1, p2);
   components_.emplace_back(ComponentType::kLinear, linears_.size() - 1);

impeller/geometry/path.h

@@ -111,6 +111,9 @@ class Path {
 
   void SetContourClosed(bool is_closed);
 
+  /// @brief Transform the path by the given offset in-place.
+  void Shift(Point shift);
+
   template <class T>
   using Applier = std::function<void(size_t index, const T& component)>;
   void EnumerateComponents(