Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Add GPU frame time to Vulkan backend using timestamp queries. #46796

Merged
auto-submit merged 13 commits into from
Oct 13, 2023
Merged

[Impeller] Add GPU frame time to Vulkan backend using timestamp queries. #46796

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4df93fc
[Impeller] add GPU start/end trace events.
Oct 11, 2023
995bb5e
++
Oct 11, 2023
4060e8b
timeline events.
Oct 12, 2023
dd6e71d
++
Oct 12, 2023
096c7e6
++
Oct 12, 2023
915652f
++
Oct 12, 2023
12870c3
dnfield review
Oct 12, 2023
4910e58
++
Oct 13, 2023
ccb89a5
Merge branch 'main' of github.com:flutter/engine into add_start_end_t…
Oct 13, 2023
e35c2ef
Update gpu_tracer_vk.cc
Oct 13, 2023
fc83a0c
Merge branch 'add_start_end_trace_events' of github.com:jonahwilliams…
Oct 13, 2023
f02f609
++
Oct 13, 2023
635ebb0
++
Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
++
  • Loading branch information
jonahwilliams committed Oct 12, 2023
commit 915652f5839e3bd5c70697f7ba0406b206b29c0c
4 changes: 4 additions & 0 deletions ci/licenses_golden/licenses_flutter
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2184,6 +2184,8 @@ ORIGIN: ../../../flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc + .
ORIGIN: ../../../flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/impeller/renderer/backend/vulkan/formats_vk.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/impeller/renderer/backend/vulkan/formats_vk.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/impeller/renderer/backend/vulkan/gpu_tracer_vk.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/impeller/renderer/backend/vulkan/gpu_tracer_vk.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/impeller/renderer/backend/vulkan/pass_bindings_cache.cc + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/impeller/renderer/backend/vulkan/pass_bindings_cache.h + ../../../flutter/LICENSE
ORIGIN: ../../../flutter/impeller/renderer/backend/vulkan/pipeline_cache_vk.cc + ../../../flutter/LICENSE
Expand Down Expand Up @@ -4945,6 +4947,8 @@ FILE: ../../../flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.cc
FILE: ../../../flutter/impeller/renderer/backend/vulkan/fence_waiter_vk.h
FILE: ../../../flutter/impeller/renderer/backend/vulkan/formats_vk.cc
FILE: ../../../flutter/impeller/renderer/backend/vulkan/formats_vk.h
FILE: ../../../flutter/impeller/renderer/backend/vulkan/gpu_tracer_vk.cc
FILE: ../../../flutter/impeller/renderer/backend/vulkan/gpu_tracer_vk.h
FILE: ../../../flutter/impeller/renderer/backend/vulkan/limits_vk.h
FILE: ../../../flutter/impeller/renderer/backend/vulkan/pass_bindings_cache.cc
FILE: ../../../flutter/impeller/renderer/backend/vulkan/pass_bindings_cache.h
Expand Down
3 changes: 2 additions & 1 deletion impeller/renderer/backend/vulkan/gpu_tracer_vk.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ GPUTracerVK::GPUTracerVK(const std::shared_ptr<ContextVK>& context)
: context_(context) {
timestamp_period_ =
context_->GetPhysicalDevice().getProperties().limits.timestampPeriod;
Copy link
Contributor

@dnfield dnfield Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to check if this is actually supported right? Otherwise the value might be meaningless.

Copy link
Contributor Author

@jonahwilliams jonahwilliams Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the cmd itself is in 1.0, but I need to check that the queue supports timestamp queries. I think this will always be supported on graphics queues though, just might not have as much resolution as we'd like.

Copy link
Contributor Author

@jonahwilliams jonahwilliams Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some tests failed due to queue contruction issues so I added some logs to see what this value ends up as ...

Copy link
Contributor Author

@jonahwilliams jonahwilliams Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, this can be zero. Good call.

Copy link
Contributor Author

@jonahwilliams jonahwilliams Oct 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

FML_LOG(ERROR) << context_->GetPhysicalDevice().getProperties().limits.timestampPeriod;
FML_LOG(ERROR)
<< context_->GetPhysicalDevice().getProperties().limits.timestampPeriod;
vk::QueryPoolCreateInfo info;
info.queryCount = kPoolSize;
info.queryType = vk::QueryType::eTimestamp;
Expand Down