Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Fix EntityPassTarget::Flip with implict MSAA. #47701

Merged
auto-submit merged 4 commits into from
Nov 6, 2023
+142 −20
Merged

[Impeller] Fix EntityPassTarget::Flip with implict MSAA. #47701

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e433a33
++
Nov 6, 2023
1a36896
++
Nov 6, 2023
85e6df9
++
Nov 6, 2023
a9fdec3
matanl review.
Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
++
  • Loading branch information
jonahwilliams committed Nov 6, 2023
commit 85e6df9d25d06abf2d53589413f52aaa7c2fb0c8
1 change: 1 addition & 0 deletions ci/licenses_golden/excluded_files
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@
../../../flutter/impeller/docs
../../../flutter/impeller/entity/contents/checkerboard_contents_unittests.cc
../../../flutter/impeller/entity/contents/filters/inputs/filter_input_unittests.cc
../../../flutter/impeller/entity/entity_pass_target_unittests.cc
../../../flutter/impeller/entity/entity_unittests.cc
../../../flutter/impeller/entity/geometry/geometry_unittests.cc
../../../flutter/impeller/entity/render_target_cache_unittests.cc
Expand Down
1 change: 1 addition & 0 deletions impeller/entity/entity_pass_target_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ TEST_P(EntityPassTargetTest, SwapWithMSAAImplicitResolve) {

ASSERT_EQ(msaa_tex, color0.texture);
ASSERT_NE(resolve_tex, color0.resolve_texture);
ASSERT_TRUE(false); // see if this runs.
Copy link
Contributor Author

@jonahwilliams jonahwilliams Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing if we have a CI config that has implicit MSAA

Copy link
Contributor Author

@jonahwilliams jonahwilliams Nov 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not! I'll need to emulate this so it can be covered.

}

} // namespace testing
Expand Down