Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Add direct tesselation of circles for DrawCircle and Round end caps #48103

Merged
auto-submit merged 9 commits into from
Nov 30, 2023
Merged

[Impeller] Add direct tesselation of circles for DrawCircle and Round end caps #48103

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
72d57eb
[Impeller] Add direct tesselation of circles for DrawCircle and Round…
flar Nov 16, 2023
63ea32b
switch to triangle strips for circles and simplify tessellation API
flar Nov 17, 2023
d498124
Fix old naming typos in comments
flar Nov 17, 2023
cab69d8
simplify vertex accumulation
flar Nov 22, 2023
cfca2e1
re-enable GPU compute tessellator for PointFields
flar Nov 22, 2023
4b638ba
move to direct HostBuffer emplacement of tessellation results
flar Nov 22, 2023
4ccdb46
Move CircleTessellator to tessellator dir and move cache to Tessellat…
flar Nov 30, 2023
aeef542
document and refine circle division computation
flar Nov 30, 2023
16fa52d
style feedback from review
flar Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
re-enable GPU compute tessellator for PointFields
  • Loading branch information
@flar
flar committed Nov 30, 2023
commit cfca2e18599099c67b9c05128a534c1d5dcaa0c0
6 changes: 2 additions & 4 deletions impeller/entity/geometry/point_field_geometry.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ GeometryResult PointFieldGeometry::GetPositionBuffer(
const ContentContext& renderer,
const Entity& entity,
RenderPass& pass) const {
if (renderer.GetDeviceCapabilities().SupportsCompute() && false) {
FML_LOG(ERROR) << "Using compute";
if (renderer.GetDeviceCapabilities().SupportsCompute()) {
return GetPositionBufferGPU(renderer, entity, pass);
}
auto vtx_builder = GetPositionBufferCPU(renderer, entity, pass);
Expand All @@ -44,8 +43,7 @@ GeometryResult PointFieldGeometry::GetPositionUVBuffer(
const ContentContext& renderer,
const Entity& entity,
RenderPass& pass) const {
if (renderer.GetDeviceCapabilities().SupportsCompute() && false) {
FML_LOG(ERROR) << "Using compute";
if (renderer.GetDeviceCapabilities().SupportsCompute()) {
return GetPositionBufferGPU(renderer, entity, pass, texture_coverage,
effect_transform);
}
Expand Down