This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add a new external texture type to Android embedder #48803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
approved these changes
Dec 8, 2023
Contributor
jonahwilliams
left a comment
jonahwilliams
left a comment
There was a problem hiding this comment.
LGTM, mostly nits on the Android API.
shell/platform/android/io/flutter/embedding/engine/renderer/FlutterRenderer.java
Outdated
Show resolved
Hide resolved
matanlurey
approved these changes
Dec 8, 2023
Contributor
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
Thanks Jonah for doing such a strong initial review.
LGTM!
| return; | ||
| } | ||
| onImage(image); | ||
| maybeCloseReader(); |
Contributor
There was a problem hiding this comment.
nit: Maybe this should go in a finally block? I'm not sure of the API - maybe IllegalStateException is the only possible outcome and it's safe.
The SurfaceProducer interface exposes only exposes a Surface to render on, abstracting away the consumer side of the external texture. The `ImageReaderSurfaceProducer` implementation of this interface is included as well as a basic test of that code. Also, a small refactor so that ImageTexture and ImageReaderSurfaceProducer can use the same native C++ code in the engine. Subsequent CLs will need to address the following: - A SurfaceTextureSurfaceProducer (your eyes are probably bleeding from that name) implementation is needed so we can support GL based systems. - Update Platform Views to use this new SurfaceProducer texture type instead of the legacy types. - Deprecate SurfaceTexture and ImageTexture external texture types. Issue #139702
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 8, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 8, 2023
flutter/engine@03c5f01...7dc51b8 2023-12-08 [email protected] Add a new external texture type to Android embedder (flutter/engine#48803) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
SurfaceProducerinterface exposes only exposes a Surface to render on, abstracting away the consumer side of the external texture.The
ImageReaderSurfaceProducerimplementation of this interface is included as well as a basic test of that code.Also, a small refactor so that
ImageTextureandImageReaderSurfaceProducercan use the same native C++ code in the engine.Subsequent CLs will need to address the following:
Related issue #139702